Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: updated payment gateways for 2023 Q3 #38646

Merged
merged 1 commit into from Jun 9, 2023

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Jun 8, 2023

All Submissions:

Changes proposed in this Pull Request:

Closes #38237.

  1. Ensure payment gateway display order is as per shown in Google sheet. The ordering would be descending (i.e: The top has the highest priority).
  2. Removed India from ppcp-gateway - others
  3. Added India to ppcp-gateway - additional
  4. Added Ecuador to mercado - others

(Although India was added to additional payment suggestions, additional payment suggestions only show up upon installation of WCPay and WCPay isn't supported for India, so there is no visible change.)

  • This PR is a very minor change/addition and does not require testing instructions (if checked you can ignore/remove the next section).

How to test the changes in this Pull Request:

  1. Start with a fresh install
  2. Go to OBW
  3. Choose Ecuador as store country
  4. Complete OBW without installing any plugins in the business step.
  5. Go to WooCommerce > Settings > Advanced > WooCommerce.com > Untick "Show Suggestions" checkbox
  6. Go to WooCommerce -> Home and choose Set up payments task.
  7. Observe that Mercado, PayPal Payments are displayed in order.
  8. Change store country to India
  9. Observe that Paypal isn't showing up

image

Test the other countries and make sure the payment gateway display order is as shown in Google sheet.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you created a changelog file for each project being changed, ie pnpm --filter=<project> changelog add?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 8, 2023
@rjchow rjchow requested review from a team, ilyasfoo and adrianduffell June 8, 2023 07:19
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Hi @ilyasfoo, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

Test Results Summary

Commit SHA: 264ab64

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 51s
E2E Tests1950010020515m 2s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow marked this pull request as ready for review June 8, 2023 07:42
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @rjchow! I wanted to copy paste the whole spreadsheet and let ChatGPT figure it out so bad. One minor missed change I think

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Follow-up PR: #38658

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @rjchow ! 🚀

@rjchow rjchow merged commit e68ff84 into trunk Jun 9, 2023
21 checks passed
@rjchow rjchow deleted the add/update-payment-gateways-2023-Q3 branch June 9, 2023 09:15
@github-actions github-actions bot added this to the 7.9.0 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the APM sections in OBW payment task
3 participants