New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: updated payment gateways for 2023 Q3 #38646
Conversation
Hi @ilyasfoo, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 264ab64
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @rjchow! I wanted to copy paste the whole spreadsheet and let ChatGPT figure it out so bad. One minor missed change I think
plugins/woocommerce/src/Admin/Features/PaymentGatewaySuggestions/DefaultPaymentGateways.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Follow-up PR: #38658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you @rjchow ! 🚀
All Submissions:
Changes proposed in this Pull Request:
Closes #38237.
(Although India was added to additional payment suggestions, additional payment suggestions only show up upon installation of WCPay and WCPay isn't supported for India, so there is no visible change.)
How to test the changes in this Pull Request:
WooCommerce > Settings > Advanced > WooCommerce.com
> Untick "Show Suggestions" checkboxWooCommerce -> Home
and choose Set up payments task.Mercado
,PayPal Payments
are displayed in order.Test the other countries and make sure the payment gateway display order is as shown in Google sheet.
Other information:
pnpm --filter=<project> changelog add
?FOR PR REVIEWER ONLY: