Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 38815 into 7.9 #38897

Merged
merged 1 commit into from Jun 22, 2023
Merged

Conversation

louwie17
Copy link
Contributor

Changes proposed in this Pull Request:

Cherry picked this PR #38815 for 7.9.

How to test the changes in this Pull Request:

Follow instructions from: #38815

…of product screens is interrupted by page unload (#38815)

* Suppress "adding new attribute failed" error message on page unload
* Only attempt to add empty attribute if page has attributes list
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jun 22, 2023
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 3e915fd

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 50s
E2E Tests1891018020814m 52s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@jonathansadowski jonathansadowski merged commit 5a4c081 into release/7.9 Jun 22, 2023
15 of 17 checks passed
@jonathansadowski jonathansadowski deleted the fix/7.9_cherry_pick_38815 branch June 22, 2023 20:42
@jonathansadowski
Copy link
Contributor

Note: I merged this as the failing tests where the ones that were skipped in trunk, and that skip wasn't cherry-picked into the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants