Fix failing tests in create shipping zones #38949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Test Results SummaryCommit SHA: 85f6a8c
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
|
Okay, so I didn’t actually change the logic — there was a problem with my local. But I did improve the locators, so I’ll let this PR stand for that. |
alopezari
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Thanks for working on this @lanej0!
As you said, only locators were updated - which is a pretty straightforward change - and the tests passed both on CI and my local environment (headless & headed), so I'm approving this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Two tests in
merchant/create-shipping-zones.spec.jswere failing because functionality changed. This fixes that, and while I was working with them, I updated the locators used in the test to modernize them.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
pnpm env:startpnpm test:e2e-pw tests/e2e-pw/tests/merchant/create-shipping-zones.spec.js