E2E: Fix skipping of core profiler in page-loads.spec.js

[rodelgc]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes #39056.

Currently, the E2E tests in page-loads.spec.js fail when it's run while the default admin user has not skipped OBW yet. This is because the if condition here, which was meant to skip the guided setup, doesn't execute -- currentPage.name will never be equal to Home.

This PR fixes this by:

• moving these lines onto a beforeAll hook so that the skipping will happen only once, rather than leaving it in the beforeEach block where it runs before each test unnecessarily.
• simplifying the if condition to rely only on whether coreProfilerEnabled is true or not.

This PR also removes these lines, as I think we no longer have a use case where the old onboarding wizard will be shown to the user.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Testing locally

1. Run the usual setup scripts for launching wp-env. But don't run any tests yet.
2. As expected, when you navigate to WooCommerce > Home, you'll be taken to the core profiler Welcome page. Do not click "Skip guided setup". But if you happen to have skipped it by accident, you can send a POST request to http://localhost:8086/wp-json/wc-admin/onboarding/profile with the following payload in order to reset the skipped state:

    {
    "skipped": false
    }

3. Run only the page-loads.spec.js file. All tests in it should pass.

   pnpm --filter=woocommerce test:e2e-pw page-loads.spec.js

Testing on the permanent sites for daily and release tests

Assuming you don't have a running wp-env local environment, and you're on the woocommerce monorepo root dir:

1. Run only pnpm install to install dependencies. No need to run the build and env:test PNPM commands.
2. Make sure that the daily and release test sites do not skip the core profiler. As mentioned earlier, do this by sending a POST request to /wp-json/wc-admin/onboarding/profile with this payload:

   {
   "skipped": false
   }

3. Run the page-loads.spec.js E2E spec against the daily and release smoke test sites using the following environment variables. Get their values from the secret store if you haven't saved them yet.

   export BASE_URL='...'
   export ADMIN_USER='...'
   export ADMIN_USER_EMAIL='...'
   export ADMIN_PASSWORD='...'
   export CUSTOMER_USER='...'
   export CUSTOMER_PASSWORD='...'
   export CUSTOMER_USER_EMAIL='...'
   export RESET_SITE=true
   pnpm --filter=woocommerce test:e2e-pw page-loads.spec.js

4. All tests should pass.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 85dba1a

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 53s
E2E Tests	190	0	0	18	0	208	17m 54s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi , @woocommerce/solaris, @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[lanej0]

Tests and re-tests as expected. LGTM!