Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Klaviyo into default free extensions for onboarding task list #39087

Merged
merged 3 commits into from Jul 7, 2023

Conversation

ecgan
Copy link
Member

@ecgan ecgan commented Jul 4, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

In this PR, we add Klaviyo into the default free extensions for onboarding marketing task list. This is shown when users turn off the marketing place suggestions in WooCommerce settings. Klaviyo should show up between Mailchimp and Creative Mail.

Before Klaviyo is installed, it should appear in the "Recommended marketing extensions" card:

image

After Klaviyo is installed, it should appear in the "Installed marketing extensions" card:

image

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Make sure that marketplace suggestions is turned off in WooCommerce settings page: /wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com
  2. Go to WooCommerce onboarding marketing task: /wp-admin/admin.php?page=wc-admin&task=marketing
  3. Klaviyo should show up under the "Recommended marketing extensions" card, between Mailchimp and Creative Mail.
  4. Click on the "Get started" button for Klaviyo. This should install Klaviyo.
  5. When the installation is complete, Klaviyo should disappear from the "Recommended marketing extensions" card, and appears in the "Installed marketing extensions" card.
  6. Click on the "Manage" button for Klaviyo. You should be directed to /wp-admin/admin.php?page=klaviyo_settings page.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement

Message

Comment

@ecgan ecgan added the focus: marketing Marketing page in WooCommerce Admin, i.e. `/wp-admin/admin.php?page=wc-admin&path=%2Fmarketing`. label Jul 4, 2023
@ecgan ecgan requested a review from a team July 4, 2023 14:49
@ecgan ecgan self-assigned this Jul 4, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Hi , @woocommerce/ventures

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Test Results Summary

Commit SHA: e004f90

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 55s
E2E Tests1900018020812m 57s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@ecgan ecgan merged commit afdc00e into trunk Jul 7, 2023
18 checks passed
@ecgan ecgan deleted the add/onboarding-task-klaviyo branch July 7, 2023 15:03
@github-actions github-actions bot added this to the 8.0.0 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: marketing Marketing page in WooCommerce Admin, i.e. `/wp-admin/admin.php?page=wc-admin&path=%2Fmarketing`. plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants