New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for free shipping handling of minimum order rule #39155
Conversation
Changes when coupons added and prices are entered and displayed inclusive of tax
Hi , Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @anastas10s-afk !
👍 Tests well, although I think in the testing instructions, the last line would be clearer as "Confirm free shipping is still available".
Thank you so much, @coreymckrill ! |
@anastas10s-afk @coreymckrill : the changes do not work anymore with WooCommerce v8.0.2. In v8.0.2, when you add the coupon, the free shipping is not available anymore (on final step 12). Could you please check what happens? Thank you very much. |
Hi @fvdbgit, this fix is merged into trunk, but it hasn't been released yet. It should go out in the 8.1.0 release. |
Changes proposed in this Pull Request:
Fixes the calculation from when
Apply minimum order rule before coupon discount
is active and prices are entered inclusive of tax and displayed that way in cart and checkout, free shipping is no longer available (based on the minimum order amount including tax), as it uses the pre-tax amount when a coupon is applied.Closes #28752 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions: