New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: feature flag for customize your store task #39397
Conversation
Test Results SummaryCommit SHA: 403c1ae
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hi @ilyasfoo, @adrianduffell, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for the legwork @rjchow! One minor comment about the PHP script still being imported.
plugins/woocommerce/src/Admin/Features/OnboardingTasks/TaskLists.php
Outdated
Show resolved
Hide resolved
8788b9f
to
0651ae6
Compare
0651ae6
to
78f3b7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick comment about optionally removing CustomizeStore
from the defunct list. LGTM anyways! 🚢
plugins/woocommerce/src/Admin/Features/OnboardingTasks/TaskLists.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! LGTM and tested well. 🚀
717c890
to
403c1ae
Compare
* add: feature flag for customize your store task * toggled core-profiler feature flag to true in dev mode
Submission Review Guidelines:
Changes proposed in this Pull Request:
How to test the changes in this Pull Request:
Note that the feature flag is disabled even in development.json because it's not ready for other dev teams to look at
Changelog entry
Significance
Type
Message
Comment