Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: feature flag for customize your store task #39397

Merged
merged 6 commits into from Aug 1, 2023

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Jul 25, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

  • Added feature flag that removes store appearance task and adds customize store task when enabled
  • Added task list item header for customize your store task
  • Made core profiler feature flagged task removal order invariant, previously it depended on the StoreDetails task being the first in the list

How to test the changes in this Pull Request:

Note that the feature flag is disabled even in development.json because it's not ready for other dev teams to look at

  1. Set up WooCommerce, toggle feature flag for 'customize-store' to true
  2. Should see the task list as below

image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

Test Results Summary

Commit SHA: 403c1ae

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 3s
E2E Tests1890019020814m 44s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow requested review from a team, ilyasfoo and adrianduffell July 25, 2023 08:01
@rjchow rjchow marked this pull request as ready for review July 25, 2023 08:01
@github-actions
Copy link
Contributor

Hi @ilyasfoo, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the legwork @rjchow! One minor comment about the PHP script still being imported.

@rjchow rjchow force-pushed the add/customize-store-feature-flag branch 2 times, most recently from 8788b9f to 0651ae6 Compare July 31, 2023 10:18
@rjchow rjchow force-pushed the add/customize-store-feature-flag branch from 0651ae6 to 78f3b7b Compare July 31, 2023 10:29
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick comment about optionally removing CustomizeStore from the defunct list. LGTM anyways! 🚢

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM and tested well. 🚀

@rjchow rjchow force-pushed the add/customize-store-feature-flag branch from 717c890 to 403c1ae Compare August 1, 2023 11:40
@rjchow rjchow merged commit 94e4682 into trunk Aug 1, 2023
23 checks passed
@rjchow rjchow deleted the add/customize-store-feature-flag branch August 1, 2023 12:28
@github-actions github-actions bot added this to the 8.1.0 milestone Aug 1, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 1, 2023
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. labels Aug 1, 2023
tommyshellberg pushed a commit that referenced this pull request Aug 7, 2023
* add: feature flag for customize your store task

* toggled core-profiler feature flag to true in dev mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants