Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include postcode in Vietnam address format #39403

Merged
merged 2 commits into from Jul 26, 2023
Merged

Conversation

jorgeatorres
Copy link
Member

@jorgeatorres jorgeatorres commented Jul 25, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

It's been reported that postcodes are, in fact, used in Vietnam.
When we originally introduced the Vietnam address format, we omitted both state and postcodes (link).

This PR adds the postcode to the address format, following the UPU's address format for Vietnam, which indicates that the postcode should go next to the province/city.

Closes #39164.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Add a product to the cart.
  2. Complete checkout for said product using Vietnam as country and any details you want. Make sure to include a postcode and address line 2.
  3. Go to the admin and to the specific order created in the previous step.
  4. Confirm that:
    • On trunk, neither "Billing Address" nor "Shipping Address" (if the product was shippable) include postcode or address line 2 information.
      Trying to edit the address does show that the postcode and address line 2 was in fact stored.
    • On this branch, both "Billing Address" and "Shipping Address" should include the postcode and address line 2 in the details.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jul 25, 2023
@jorgeatorres jorgeatorres added focus: checkout Issues related to checkout page. focus: i18n The issue/PR is related to internationalization. and removed plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: checkout Issues related to checkout page. labels Jul 25, 2023
@jorgeatorres jorgeatorres requested review from a team and rrennick and removed request for a team July 25, 2023 14:34
@github-actions
Copy link
Contributor

Hi @rrennick,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: bc1bb61

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 8s
E2E Tests1890019020812m 56s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@rrennick rrennick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this one. Tested great. I added address 2 to the testing instructions as it was added to the display as well.

@rrennick rrennick added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jul 26, 2023
@nigeljamesstevenson nigeljamesstevenson merged commit 66f852f into trunk Jul 26, 2023
29 checks passed
@nigeljamesstevenson nigeljamesstevenson deleted the fix/39164 branch July 26, 2023 18:13
@github-actions github-actions bot added this to the 8.1.0 milestone Jul 26, 2023
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: i18n The issue/PR is related to internationalization. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postcode for Vietnam is not visible on the order
3 participants