[Product Block Editor] Add require password block field #39464

nathanss · 2023-07-27T19:09:31Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Create 'woocommerce/product-password-fields' block and use it on the block product editor

Closes #39127 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Open the block product editor.
Go to 'Organization' tab.
Check 'Require a password' checkbox.
See that the password field appears.
Fill in any value.
Save it and check that it is persisted. Optional: toggle to the legacy editor and see if the same value is there as well.
Uncheck the 'Require a password' checkbox.
Save it and see if the same state is persisted (The password field is cleared when it's hidden).

Changelog entry

Automatically create a changelog entry from the details below.

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Comment

github-actions · 2023-07-27T19:34:29Z

Test Results Summary

Commit SHA: 8a58a6e

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 13s
E2E Tests	189	0	0	19	0	208	12m 43s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

mattsherman

Tested and overall works as expected, with one edge case:

Removing password from field and saving/updating the product removes the password but keeps the "Require a password" checked

Left a few comments/questions, all pretty minor.

Nice work on this... let me know when you are ready for a re-review.

mattsherman · 2023-07-28T14:50:31Z

packages/js/product-editor/src/blocks/password/block.json

+{
+	"$schema": "https://schemas.wp.org/trunk/block.json",
+	"apiVersion": 2,
+	"name": "woocommerce/product-password-fields",


It feels a little off to use a plural to describe this. I understand why, but I'd probably go with woocommerce/product-password-field instead, as it feels more natural.

packages/js/product-editor/src/blocks/password/edit.tsx

mattsherman · 2023-07-28T15:07:43Z

packages/js/product-editor/src/blocks/password/editor.scss

+	.components-base-control {
+		margin-bottom: $gap;
+	}


This feels like it is using knowledge of the implementation of the components (especially the CheckboxControl)...

It would probably be more robust to set a class on the CheckboxControl, and the BaseControl you are using and set the margin using that.

mattsherman · 2023-07-28T15:08:44Z

packages/js/product-editor/src/blocks/password/index.ts

+export const settings: Partial<
+	BlockConfiguration< RequirePasswordBlockAttributes >
+> = {
+	example: {},


Do we need this at all? I'd just leave it off.

mattsherman

Re-tested and works well still. Thanks for making the requested changes.

The edge case from my initial review still stands:

Tested and overall works as expected, with one edge case:

Removing password from field and saving/updating the product removes the password but keeps the "Require a password" checked

If that is not an easy fix, I'm okay with leaving that to a follow-up PR, as it is definitely an edge case, and while it looks slightly confusing from a UI perspective, things are handled correctly from a data standpoint, so I don't think it will cause any real user issues.

* Add post password to API * Add changelog * Fix phpcs issue * Remove post_password from tests * Add additional property to test * Increment number of properties in product schema * Update the post when post_password changes * Start adding password block * Add css and import it * Refactor attributes and erase password when checkbox is unchecked * Add changelogs * Remove unused imports * Rename 'fields' to 'field' * Refactor CSS * Remove example object

@andfinally

commit d7c6924 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Aug 10 11:52:46 2023 +0100 Addressing feedback. Removed unneeded internal dependencies comment. commit 216e306 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Aug 10 11:51:45 2023 +0100 Addressing feedback. Sanitizing `comments` input before we send it to Tracks. Whitespace. commit 817bcb7 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:37:04 2023 +0100 Made selected-item style more like existing ones (background color) commit 57af273 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:25:14 2023 +0100 Namespaced more translatable strings commit ef293ad Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:21:35 2023 +0100 Moved <TextareaControl> out of <p> (prevents DOM "<div> in <p>" warning) commit efc4a59 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:18:57 2023 +0100 Linter appeasement commit c7efaf7 Merge: 8b3ff1c 2a8d47c Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:47:29 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit 8b3ff1c Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:20:20 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/likert-scale/likert-scale.scss Co-authored-by: Kyle Nel <22053773+kdevnel@users.noreply.github.com> commit 4be3827 Merge: 19e3aa1 789fdf3 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:19:12 2023 +0100 Merge branch 'add/wccom-17602-marketplace-feedback-component' of https://github.com/woocommerce/woocommerce into add/wccom-17602-marketplace-feedback-component commit 19e3aa1 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:18:58 2023 +0100 Remove unused TextControl commit 789fdf3 Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:16:09 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/likert-scale/likert-scale.tsx Co-authored-by: And Finally <andfinally@users.noreply.github.com> commit d8db9a4 Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:15:25 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/feedback-modal/feedback-modal.tsx Co-authored-by: And Finally <andfinally@users.noreply.github.com> commit 6f0ab9a Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:08:10 2023 +0100 Switched pencil icon commit 5bea666 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 14:36:32 2023 +0100 Ensured snackbar appears at bottom (thanks @andfinally for the analysis!) commit b49a19f Merge: 0076c28 172234b Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 13:59:18 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit 0076c28 Author: Dan Q <dan@danq.me> Date: Tue Aug 8 07:59:42 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/feedback-modal/feedback-modal.tsx commit 05f1606 Author: Dan Q <dan@danq.me> Date: Tue Aug 8 07:58:36 2023 +0100 Fixed merge commit b73a324 Merge: df92adf a807040 Author: Dan Q <danq@automattic.com> Date: Tue Aug 8 07:56:33 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit df92adf Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:53:17 2023 +0100 i18n: make "Additional thoughts" translatable commit b043355 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:36:41 2023 +0100 Add feedback modal to content commit deae2e6 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:33:43 2023 +0100 Validation/validation feedback on likert scales commit 50aadee Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:27:48 2023 +0100 Remove unused props commit 928a62d Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:27:15 2023 +0100 Don't ask for feedback if dismissed earlier today commit 9a8b896 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:16:18 2023 +0100 Enable suppression by multiple dismissal or by submission commit 521181a Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:01:26 2023 +0100 Add a max date This is important because we don't want to ask for feedback on a "new" marketplace forever, and we can't necessarily rely on being able to remove the dialog in a future version of WooCommerce (because some users might never upgrade beyond this version). commit 0f36d36 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 08:47:04 2023 +0100 Removed email field commit b83ca81 Author: Dan Q <danq@automattic.com> Date: Fri Aug 4 12:18:54 2023 +0100 CES push from feedback form commit e5b6e5b Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 16:33:55 2023 +0100 Hook up events. Fix a11y (keyboard navigation). commit b679495 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 15:49:24 2023 +0100 Initial icon in snackbar commit b702be9 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 15:23:16 2023 +0100 Use a snackbar notice to open the feedback modal commit 06736e4 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 14:25:35 2023 +0100 Feedback modal design matching commit 7c3a969 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:40:35 2023 +0100 Basic layout of Likert scales on feedback component commit 3c3f0e0 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:25:15 2023 +0100 Tidier order of likert items commit 8176e88 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:21:52 2023 +0100 Initial skeleton for WooCommerce Marketplace/Extensions feedback component commit 62a4bfa Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Thu Jul 27 15:47:54 2023 +0300 👌 Use admin theme color for select2 commit 2681177 Author: Nathan Silveira <nsschneider1@gmail.com> Date: Fri Jul 28 14:40:18 2023 -0300 [ Product Block Editor ] Create Variation options block (#39256) * Add support for variable products * Add 'hello world' block to variations tab * Add product-section block to template * Add AttributeControl component to screen * Add changelog * Change labels * Make a copy of AttributeControl to VariationOptionsControl to allow the fields to evolve separately in future * Fix tests * Add changelog to woocommerce * Fix alert error * Remove copied control and start adapting attribute control to handle both scenarios * Add -field to block name * Revert "Add -field to block name" This reverts commit 50e1ee6. * Revert "Revert "Add -field to block name"" This reverts commit eee0441. * Extract more labels * Hide drag handle in variation options commit 575bbae Author: Nathan Silveira <nsschneider1@gmail.com> Date: Fri Jul 28 14:05:03 2023 -0300 [Product Block Editor] Add require password block field (#39464) * Add post password to API * Add changelog * Fix phpcs issue * Remove post_password from tests * Add additional property to test * Increment number of properties in product schema * Update the post when post_password changes * Start adding password block * Add css and import it * Refactor attributes and erase password when checkbox is unchecked * Add changelogs * Remove unused imports * Rename 'fields' to 'field' * Refactor CSS * Remove example object commit bb390b1 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Thu Jul 27 15:18:10 2023 -0700 Update template version commit 87ae3d1 Author: github-actions <github-actions@github.com> Date: Thu Jul 20 19:12:38 2023 +0000 Add changefile(s) from automation for the following project(s): woocommerce commit 9c7c58c Author: Chris McNeill <82999806+csmcneill@users.noreply.github.com> Date: Thu Jul 20 13:53:07 2023 -0500 Removes the "for your state" string from the checkout page if there are no current payment methods available. commit d4893c4 Author: Paul Sealock <psealock@gmail.com> Date: Fri Jul 28 11:10:29 2023 +1200 Monorepo Utils: Fix no merge base in changefile script (#39467) * when checking out remote branch, ensure git history is there to find common ancestor for git diff * remove unshallow commit 144e873 Author: Leif Singer <leif@automattic.com> Date: Thu Jul 27 22:29:59 2023 +0200 Optimize system status tests (#39363) commit fccc62d Author: Nathan Silveira <nsschneider1@gmail.com> Date: Thu Jul 27 13:02:36 2023 -0300 [Product Block Editor] Add post_password parameter to the Woo product REST api (#39438) * Add post password to API * Add changelog * Fix phpcs issue * Remove post_password from tests * Add additional property to test * Increment number of properties in product schema * Update the post when post_password changes commit cb787ab Author: Leif Singer <leif@automattic.com> Date: Thu Jul 27 14:06:55 2023 +0200 Shard unit test runs (#39362) commit d7e5703 Author: Jorge Torres <jorge.torres@automattic.com> Date: Tue Jul 25 11:25:49 2023 -0300 Add changelog commit 8cf45dc Author: Jorge Torres <jorge.torres@automattic.com> Date: Tue Jul 25 11:25:29 2023 -0300 Include postcode in Vietnam address format commit 527701f Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 18 10:55:32 2023 +0300 Update count color, use admin theme commit 35c1592 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 15:10:29 2023 +0300 Update helper css to use admin theme color commit bf95490 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 14:06:54 2023 +0300 Changelog commit eb7b83b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:52:50 2023 +0300 Hover on orders view icon, use admin theme color commit 378d005 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:51:49 2023 +0300 Store alerts update - use admin theme colors commit 603cbd3 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:50:02 2023 +0300 Components empty content icon color commit 3c9e460 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 16:34:49 2023 +0300 Finally, that's the changelog :) commit 8f40038 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 16:16:28 2023 +0300 Changelog commit 016ae26 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:43:45 2023 +0300 Changelog (again) commit df07d17 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:24:18 2023 +0300 Changelog commit 30f4380 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:09:15 2023 +0300 Remove styles from buttons, as theme colors.css is taking care of them commit 5497cef Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:01:36 2023 +0300 Applied review comments commit 57d4f68 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:43:05 2023 +0300 Remove hardcoded text color wherever variable background color is used commit ea19b23 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:21:37 2023 +0300 Fix activation css to use wp-admin-theme-color commit dbffd6b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:04:49 2023 +0300 Use new branding colors in activation and wc setup commit 68a83a0 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 17:45:39 2023 +0300 Shipping methods empty state follow theme colors (and minor improvements) commit 366ee82 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:43:39 2023 +0300 Use page-title-action instead of deprecated add-new-h2 commit f62221c Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:43:09 2023 +0300 Untested extensions modal uses theme colors commit 4bd8f6b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:41:10 2023 +0300 Auth page uses Woo colors, according to branding commit e637035 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:40:41 2023 +0300 Importer/Exporter use admin theme color commit 6a76fd7 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:38:18 2023 +0300 Breadcrump up link use admin theme color commit 1b67a7f Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:37:15 2023 +0300 Email status use admin theme color commit 3b69ad1 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:35:20 2023 +0300 Input toggles use admin theme color commit b9cd91c Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:34:56 2023 +0300 WooCommerce message use admin theme color commit 5c1dfad Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:34:24 2023 +0300 Blankstate buttons follow theme colors commit 20d9981 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:24:57 2023 +0300 Change default WooCommerce color commit 16d295d Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Tue Jul 25 11:07:52 2023 -0700 Use the LegacyProxy to invoke get_plugins, remove CodeHacking usage commit 5c0d161 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Fri Jun 23 15:27:55 2023 -0700 Add changelog file commit 28e4ce9 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Fri Jun 23 15:23:42 2023 -0700 WC Tracker: Add unit test for plugin feature compat data In #38849 a change was made that allowed the class mocking necessary for this test to happen in a way that wouldn't interfere with other unit tests. Fixes #38720 commit f479625 Author: Sam Seay <samueljseay@gmail.com> Date: Wed Jul 26 12:54:45 2023 +0800 WooCommerce Docs: Fix a bug where passing full file urls made ids unstable. (#39357) Fix a bug where passing full file urls made ids unstable. commit ce79211 Author: Vedanshu Jain <vedanshu.jain.2012@gmail.com> Date: Tue Jul 25 18:00:03 2023 +0530 Support inserting NULL values for strict DB mode (#39396) * Support inserting NULL values for strict DB mode * Set default date for placeholder order to support strict MySQL. * Add unit test to verify strict mode also works. * Make HPOS behavior of modified date consistent with WP_Post. In HPOS we were leaving modified date to be empty, while WP_Post set it to the created date if modified date is null. commit b1cb905 Author: Paul Sealock <psealock@gmail.com> Date: Tue Jul 25 15:29:43 2023 +1200 WooCommerce Docs: Handle multiple category posts (#39352) commit ddf9a77 Author: Paul Sealock <psealock@gmail.com> Date: Tue Jul 25 10:03:01 2023 +1200 Monrepo Utils code-freeze: Update version bump to modify release branches (#39243) commit 91a0fba Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 24 14:21:47 2023 -0500 Delete changelog files based on PR 39327 (#39388) Delete changelog files for 39327 Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com> commit 8ae03a5 Author: Moon <moon.kyong@automattic.com> Date: Tue Jul 25 04:13:13 2023 +0900 Update/39325 typo in core profiler data sharing copy (#39327) * Fix grammar in data-sharing agreement copy * Add changelog * Put , * Add brackets * Move learn more link inside the bracket * Update test snapshot * Fix grammar * Update test snapshot commit 41d052b Author: RJ <27843274+rjchow@users.noreply.github.com> Date: Mon Jul 24 20:34:38 2023 +0800 dev: core profiler pages storybook (#39046) * dev: core profiler pages storybook * changed css path to pre-build zip path commit c119d8f Author: Rodel Calasagsag <rodel.calasagsag@automattic.com> Date: Thu Jul 20 09:30:43 2023 +0800 Add changelog commit 598adeb Author: Rodel Calasagsag <rodel.calasagsag@automattic.com> Date: Wed Jul 19 18:56:39 2023 +0800 Fix flakiness commit 8f14d89 Author: Jon Lane <jon.lane@automattic.com> Date: Fri Jul 21 13:22:07 2023 -0700 Skip tax rates test if CI commit b7913a7 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 15:50:50 2023 -0700 Changelog commit 4c3ef8e Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 15:49:02 2023 -0700 Skip failing tests commit c3e7652 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:28:40 2023 -0700 Update config to use API URL commit 149c969 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:26:59 2023 -0700 Update API URL in workflow and run all API tests commit be992dc Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:22:04 2023 -0700 Run global setup commit 00f55c3 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:20:36 2023 -0700 Perform a site reset if running on CI commit b128f07 Author: Sam Seay <samueljseay@gmail.com> Date: Sat Jul 22 12:22:55 2023 +0800 WooCommerce Docs: Add support for more core block conversion (#39244) * WIP extend support for frontmatter in manifests. * Change some of the prop names in the frontmatter support, add tests. * WIP support new frontmatter in plugin. * Improve category processing. * restructure the docs to have a nested category with no index. * Add WP test stubs to dev. * Add tests for the ManifestProcessor. * Add param docs to function * Store post meta on posts when they are updated or created. Add supporting tests. * WIP supporting more core block types. * Fix bugs in conversion. * Adjust conversion for issues with tables, blockquotes, code. * Resolve pnpm lock conflicts * Return manifest to state in trunk. * Return pnpm lock to trunk state. * Update fixture for new md content. commit 0243bfd Merge: 19ba93c 34e490f Author: And Finally <andfinally@users.noreply.github.com> Date: Wed Jul 26 14:03:25 2023 +0100 Add new top admin bar to marketplace (#39145) commit 34e490f Author: And Finally <andfinally@users.noreply.github.com> Date: Wed Jul 26 12:31:59 2023 +0100 Tidying history for #39145. Copied changes from `add/wccom-17419-marketplace-top-admin-bar`. Deleting unused import. Addressing CSS linter errors. commit 19ba93c Merge: 30e23d2 28cb100 Author: Kyle Nel <22053773+kdevnel@users.noreply.github.com> Date: Wed Jul 26 12:52:39 2023 +0200 Setup marketplace React skeleton layout (#39382) commit 28cb100 Author: Kyle Nel <22053773+kdevnel@users.noreply.github.com> Date: Tue Jul 4 14:08:50 2023 +0200 Add skeleton and cherry-picked commits - Reset layout to allow full width - Added Footer & IconWithText components Add temporary placeholder components All components here are temporary and can be removed/replaced when their relevant PR is ready. Add marketplace footer component The component is added using a SlotFill to use the existing WC Admin footer and utilise full width correctly. Setup initial content area layout Update tab styles Setup styling to match latest design Finalise footer, wide layout, and tidy styles - Applies the wide layout from latest MVP design - Applies the correct footer links to titles - Some general style tidying Organise styles and setup variables Swap to using CSS Grid for layouts Update breakpoints Restructure style naming and update to core styles Add translation in some places In-app marketplace search component. Cleaned up the commit history of this branch. Copied changes from these commits: e982842 9ca2ae3 e478157 976811c 46eafdf Deleted unused import. commit 30e23d2 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Jul 20 17:00:22 2023 +0100 Changed `Tabs` to use `useQuery` instead of `getQuery`, so the browser back button will work. Changed submenu item name back to `Extensions`, and keeping it in the current order within the WooCommerce menu. Changed `path` value to `extensions`. commit a2b878e Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Jul 20 14:53:06 2023 +0100 First commit. This contains the changes from `update/react-marketplace`, reviewed in #38885.

@andfinally

commit d7c6924 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Aug 10 11:52:46 2023 +0100 Addressing feedback. Removed unneeded internal dependencies comment. commit 216e306 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Aug 10 11:51:45 2023 +0100 Addressing feedback. Sanitizing `comments` input before we send it to Tracks. Whitespace. commit 817bcb7 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:37:04 2023 +0100 Made selected-item style more like existing ones (background color) commit 57af273 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:25:14 2023 +0100 Namespaced more translatable strings commit ef293ad Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:21:35 2023 +0100 Moved <TextareaControl> out of <p> (prevents DOM "<div> in <p>" warning) commit efc4a59 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:18:57 2023 +0100 Linter appeasement commit c7efaf7 Merge: 8b3ff1c 2a8d47c Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:47:29 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit 8b3ff1c Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:20:20 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/likert-scale/likert-scale.scss Co-authored-by: Kyle Nel <22053773+kdevnel@users.noreply.github.com> commit 4be3827 Merge: 19e3aa1 789fdf3 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:19:12 2023 +0100 Merge branch 'add/wccom-17602-marketplace-feedback-component' of https://github.com/woocommerce/woocommerce into add/wccom-17602-marketplace-feedback-component commit 19e3aa1 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:18:58 2023 +0100 Remove unused TextControl commit 789fdf3 Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:16:09 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/likert-scale/likert-scale.tsx Co-authored-by: And Finally <andfinally@users.noreply.github.com> commit d8db9a4 Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:15:25 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/feedback-modal/feedback-modal.tsx Co-authored-by: And Finally <andfinally@users.noreply.github.com> commit 6f0ab9a Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:08:10 2023 +0100 Switched pencil icon commit 5bea666 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 14:36:32 2023 +0100 Ensured snackbar appears at bottom (thanks @andfinally for the analysis!) commit b49a19f Merge: 0076c28 172234b Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 13:59:18 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit 0076c28 Author: Dan Q <dan@danq.me> Date: Tue Aug 8 07:59:42 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/feedback-modal/feedback-modal.tsx commit 05f1606 Author: Dan Q <dan@danq.me> Date: Tue Aug 8 07:58:36 2023 +0100 Fixed merge commit b73a324 Merge: df92adf a807040 Author: Dan Q <danq@automattic.com> Date: Tue Aug 8 07:56:33 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit df92adf Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:53:17 2023 +0100 i18n: make "Additional thoughts" translatable commit b043355 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:36:41 2023 +0100 Add feedback modal to content commit deae2e6 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:33:43 2023 +0100 Validation/validation feedback on likert scales commit 50aadee Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:27:48 2023 +0100 Remove unused props commit 928a62d Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:27:15 2023 +0100 Don't ask for feedback if dismissed earlier today commit 9a8b896 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:16:18 2023 +0100 Enable suppression by multiple dismissal or by submission commit 521181a Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:01:26 2023 +0100 Add a max date This is important because we don't want to ask for feedback on a "new" marketplace forever, and we can't necessarily rely on being able to remove the dialog in a future version of WooCommerce (because some users might never upgrade beyond this version). commit 0f36d36 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 08:47:04 2023 +0100 Removed email field commit b83ca81 Author: Dan Q <danq@automattic.com> Date: Fri Aug 4 12:18:54 2023 +0100 CES push from feedback form commit e5b6e5b Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 16:33:55 2023 +0100 Hook up events. Fix a11y (keyboard navigation). commit b679495 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 15:49:24 2023 +0100 Initial icon in snackbar commit b702be9 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 15:23:16 2023 +0100 Use a snackbar notice to open the feedback modal commit 06736e4 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 14:25:35 2023 +0100 Feedback modal design matching commit 7c3a969 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:40:35 2023 +0100 Basic layout of Likert scales on feedback component commit 3c3f0e0 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:25:15 2023 +0100 Tidier order of likert items commit 8176e88 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:21:52 2023 +0100 Initial skeleton for WooCommerce Marketplace/Extensions feedback component commit 62a4bfa Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Thu Jul 27 15:47:54 2023 +0300 👌 Use admin theme color for select2 commit 2681177 Author: Nathan Silveira <nsschneider1@gmail.com> Date: Fri Jul 28 14:40:18 2023 -0300 [ Product Block Editor ] Create Variation options block (#39256) * Add support for variable products * Add 'hello world' block to variations tab * Add product-section block to template * Add AttributeControl component to screen * Add changelog * Change labels * Make a copy of AttributeControl to VariationOptionsControl to allow the fields to evolve separately in future * Fix tests * Add changelog to woocommerce * Fix alert error * Remove copied control and start adapting attribute control to handle both scenarios * Add -field to block name * Revert "Add -field to block name" This reverts commit 50e1ee6. * Revert "Revert "Add -field to block name"" This reverts commit eee0441. * Extract more labels * Hide drag handle in variation options commit 575bbae Author: Nathan Silveira <nsschneider1@gmail.com> Date: Fri Jul 28 14:05:03 2023 -0300 [Product Block Editor] Add require password block field (#39464) * Add post password to API * Add changelog * Fix phpcs issue * Remove post_password from tests * Add additional property to test * Increment number of properties in product schema * Update the post when post_password changes * Start adding password block * Add css and import it * Refactor attributes and erase password when checkbox is unchecked * Add changelogs * Remove unused imports * Rename 'fields' to 'field' * Refactor CSS * Remove example object commit bb390b1 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Thu Jul 27 15:18:10 2023 -0700 Update template version commit 87ae3d1 Author: github-actions <github-actions@github.com> Date: Thu Jul 20 19:12:38 2023 +0000 Add changefile(s) from automation for the following project(s): woocommerce commit 9c7c58c Author: Chris McNeill <82999806+csmcneill@users.noreply.github.com> Date: Thu Jul 20 13:53:07 2023 -0500 Removes the "for your state" string from the checkout page if there are no current payment methods available. commit d4893c4 Author: Paul Sealock <psealock@gmail.com> Date: Fri Jul 28 11:10:29 2023 +1200 Monorepo Utils: Fix no merge base in changefile script (#39467) * when checking out remote branch, ensure git history is there to find common ancestor for git diff * remove unshallow commit 144e873 Author: Leif Singer <leif@automattic.com> Date: Thu Jul 27 22:29:59 2023 +0200 Optimize system status tests (#39363) commit fccc62d Author: Nathan Silveira <nsschneider1@gmail.com> Date: Thu Jul 27 13:02:36 2023 -0300 [Product Block Editor] Add post_password parameter to the Woo product REST api (#39438) * Add post password to API * Add changelog * Fix phpcs issue * Remove post_password from tests * Add additional property to test * Increment number of properties in product schema * Update the post when post_password changes commit cb787ab Author: Leif Singer <leif@automattic.com> Date: Thu Jul 27 14:06:55 2023 +0200 Shard unit test runs (#39362) commit d7e5703 Author: Jorge Torres <jorge.torres@automattic.com> Date: Tue Jul 25 11:25:49 2023 -0300 Add changelog commit 8cf45dc Author: Jorge Torres <jorge.torres@automattic.com> Date: Tue Jul 25 11:25:29 2023 -0300 Include postcode in Vietnam address format commit 527701f Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 18 10:55:32 2023 +0300 Update count color, use admin theme commit 35c1592 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 15:10:29 2023 +0300 Update helper css to use admin theme color commit bf95490 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 14:06:54 2023 +0300 Changelog commit eb7b83b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:52:50 2023 +0300 Hover on orders view icon, use admin theme color commit 378d005 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:51:49 2023 +0300 Store alerts update - use admin theme colors commit 603cbd3 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:50:02 2023 +0300 Components empty content icon color commit 3c9e460 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 16:34:49 2023 +0300 Finally, that's the changelog :) commit 8f40038 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 16:16:28 2023 +0300 Changelog commit 016ae26 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:43:45 2023 +0300 Changelog (again) commit df07d17 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:24:18 2023 +0300 Changelog commit 30f4380 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:09:15 2023 +0300 Remove styles from buttons, as theme colors.css is taking care of them commit 5497cef Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:01:36 2023 +0300 Applied review comments commit 57d4f68 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:43:05 2023 +0300 Remove hardcoded text color wherever variable background color is used commit ea19b23 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:21:37 2023 +0300 Fix activation css to use wp-admin-theme-color commit dbffd6b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:04:49 2023 +0300 Use new branding colors in activation and wc setup commit 68a83a0 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 17:45:39 2023 +0300 Shipping methods empty state follow theme colors (and minor improvements) commit 366ee82 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:43:39 2023 +0300 Use page-title-action instead of deprecated add-new-h2 commit f62221c Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:43:09 2023 +0300 Untested extensions modal uses theme colors commit 4bd8f6b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:41:10 2023 +0300 Auth page uses Woo colors, according to branding commit e637035 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:40:41 2023 +0300 Importer/Exporter use admin theme color commit 6a76fd7 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:38:18 2023 +0300 Breadcrump up link use admin theme color commit 1b67a7f Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:37:15 2023 +0300 Email status use admin theme color commit 3b69ad1 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:35:20 2023 +0300 Input toggles use admin theme color commit b9cd91c Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:34:56 2023 +0300 WooCommerce message use admin theme color commit 5c1dfad Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:34:24 2023 +0300 Blankstate buttons follow theme colors commit 20d9981 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:24:57 2023 +0300 Change default WooCommerce color commit 16d295d Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Tue Jul 25 11:07:52 2023 -0700 Use the LegacyProxy to invoke get_plugins, remove CodeHacking usage commit 5c0d161 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Fri Jun 23 15:27:55 2023 -0700 Add changelog file commit 28e4ce9 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Fri Jun 23 15:23:42 2023 -0700 WC Tracker: Add unit test for plugin feature compat data In #38849 a change was made that allowed the class mocking necessary for this test to happen in a way that wouldn't interfere with other unit tests. Fixes #38720 commit f479625 Author: Sam Seay <samueljseay@gmail.com> Date: Wed Jul 26 12:54:45 2023 +0800 WooCommerce Docs: Fix a bug where passing full file urls made ids unstable. (#39357) Fix a bug where passing full file urls made ids unstable. commit ce79211 Author: Vedanshu Jain <vedanshu.jain.2012@gmail.com> Date: Tue Jul 25 18:00:03 2023 +0530 Support inserting NULL values for strict DB mode (#39396) * Support inserting NULL values for strict DB mode * Set default date for placeholder order to support strict MySQL. * Add unit test to verify strict mode also works. * Make HPOS behavior of modified date consistent with WP_Post. In HPOS we were leaving modified date to be empty, while WP_Post set it to the created date if modified date is null. commit b1cb905 Author: Paul Sealock <psealock@gmail.com> Date: Tue Jul 25 15:29:43 2023 +1200 WooCommerce Docs: Handle multiple category posts (#39352) commit ddf9a77 Author: Paul Sealock <psealock@gmail.com> Date: Tue Jul 25 10:03:01 2023 +1200 Monrepo Utils code-freeze: Update version bump to modify release branches (#39243) commit 91a0fba Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 24 14:21:47 2023 -0500 Delete changelog files based on PR 39327 (#39388) Delete changelog files for 39327 Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com> commit 8ae03a5 Author: Moon <moon.kyong@automattic.com> Date: Tue Jul 25 04:13:13 2023 +0900 Update/39325 typo in core profiler data sharing copy (#39327) * Fix grammar in data-sharing agreement copy * Add changelog * Put , * Add brackets * Move learn more link inside the bracket * Update test snapshot * Fix grammar * Update test snapshot commit 41d052b Author: RJ <27843274+rjchow@users.noreply.github.com> Date: Mon Jul 24 20:34:38 2023 +0800 dev: core profiler pages storybook (#39046) * dev: core profiler pages storybook * changed css path to pre-build zip path commit c119d8f Author: Rodel Calasagsag <rodel.calasagsag@automattic.com> Date: Thu Jul 20 09:30:43 2023 +0800 Add changelog commit 598adeb Author: Rodel Calasagsag <rodel.calasagsag@automattic.com> Date: Wed Jul 19 18:56:39 2023 +0800 Fix flakiness commit 8f14d89 Author: Jon Lane <jon.lane@automattic.com> Date: Fri Jul 21 13:22:07 2023 -0700 Skip tax rates test if CI commit b7913a7 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 15:50:50 2023 -0700 Changelog commit 4c3ef8e Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 15:49:02 2023 -0700 Skip failing tests commit c3e7652 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:28:40 2023 -0700 Update config to use API URL commit 149c969 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:26:59 2023 -0700 Update API URL in workflow and run all API tests commit be992dc Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:22:04 2023 -0700 Run global setup commit 00f55c3 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:20:36 2023 -0700 Perform a site reset if running on CI commit b128f07 Author: Sam Seay <samueljseay@gmail.com> Date: Sat Jul 22 12:22:55 2023 +0800 WooCommerce Docs: Add support for more core block conversion (#39244) * WIP extend support for frontmatter in manifests. * Change some of the prop names in the frontmatter support, add tests. * WIP support new frontmatter in plugin. * Improve category processing. * restructure the docs to have a nested category with no index. * Add WP test stubs to dev. * Add tests for the ManifestProcessor. * Add param docs to function * Store post meta on posts when they are updated or created. Add supporting tests. * WIP supporting more core block types. * Fix bugs in conversion. * Adjust conversion for issues with tables, blockquotes, code. * Resolve pnpm lock conflicts * Return manifest to state in trunk. * Return pnpm lock to trunk state. * Update fixture for new md content. commit 0243bfd Merge: 19ba93c 34e490f Author: And Finally <andfinally@users.noreply.github.com> Date: Wed Jul 26 14:03:25 2023 +0100 Add new top admin bar to marketplace (#39145) commit 34e490f Author: And Finally <andfinally@users.noreply.github.com> Date: Wed Jul 26 12:31:59 2023 +0100 Tidying history for #39145. Copied changes from `add/wccom-17419-marketplace-top-admin-bar`. Deleting unused import. Addressing CSS linter errors. commit 19ba93c Merge: 30e23d2 28cb100 Author: Kyle Nel <22053773+kdevnel@users.noreply.github.com> Date: Wed Jul 26 12:52:39 2023 +0200 Setup marketplace React skeleton layout (#39382) commit 28cb100 Author: Kyle Nel <22053773+kdevnel@users.noreply.github.com> Date: Tue Jul 4 14:08:50 2023 +0200 Add skeleton and cherry-picked commits - Reset layout to allow full width - Added Footer & IconWithText components Add temporary placeholder components All components here are temporary and can be removed/replaced when their relevant PR is ready. Add marketplace footer component The component is added using a SlotFill to use the existing WC Admin footer and utilise full width correctly. Setup initial content area layout Update tab styles Setup styling to match latest design Finalise footer, wide layout, and tidy styles - Applies the wide layout from latest MVP design - Applies the correct footer links to titles - Some general style tidying Organise styles and setup variables Swap to using CSS Grid for layouts Update breakpoints Restructure style naming and update to core styles Add translation in some places In-app marketplace search component. Cleaned up the commit history of this branch. Copied changes from these commits: e982842 9ca2ae3 e478157 976811c 46eafdf Deleted unused import. commit 30e23d2 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Jul 20 17:00:22 2023 +0100 Changed `Tabs` to use `useQuery` instead of `getQuery`, so the browser back button will work. Changed submenu item name back to `Extensions`, and keeping it in the current order within the WooCommerce menu. Changed `path` value to `extensions`. commit a2b878e Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Jul 20 14:53:06 2023 +0100 First commit. This contains the changes from `update/react-marketplace`, reviewed in #38885. Addressing linter errors.

@andfinally

commit d7c6924 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Aug 10 11:52:46 2023 +0100 Addressing feedback. Removed unneeded internal dependencies comment. commit 216e306 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Aug 10 11:51:45 2023 +0100 Addressing feedback. Sanitizing `comments` input before we send it to Tracks. Whitespace. commit 817bcb7 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:37:04 2023 +0100 Made selected-item style more like existing ones (background color) commit 57af273 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:25:14 2023 +0100 Namespaced more translatable strings commit ef293ad Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:21:35 2023 +0100 Moved <TextareaControl> out of <p> (prevents DOM "<div> in <p>" warning) commit efc4a59 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 16:18:57 2023 +0100 Linter appeasement commit c7efaf7 Merge: 8b3ff1c 2a8d47c Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:47:29 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit 8b3ff1c Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:20:20 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/likert-scale/likert-scale.scss Co-authored-by: Kyle Nel <22053773+kdevnel@users.noreply.github.com> commit 4be3827 Merge: 19e3aa1 789fdf3 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:19:12 2023 +0100 Merge branch 'add/wccom-17602-marketplace-feedback-component' of https://github.com/woocommerce/woocommerce into add/wccom-17602-marketplace-feedback-component commit 19e3aa1 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:18:58 2023 +0100 Remove unused TextControl commit 789fdf3 Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:16:09 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/likert-scale/likert-scale.tsx Co-authored-by: And Finally <andfinally@users.noreply.github.com> commit d8db9a4 Author: Dan Q <dan@danq.me> Date: Wed Aug 9 15:15:25 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/feedback-modal/feedback-modal.tsx Co-authored-by: And Finally <andfinally@users.noreply.github.com> commit 6f0ab9a Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 15:08:10 2023 +0100 Switched pencil icon commit 5bea666 Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 14:36:32 2023 +0100 Ensured snackbar appears at bottom (thanks @andfinally for the analysis!) commit b49a19f Merge: 0076c28 172234b Author: Dan Q <danq@automattic.com> Date: Wed Aug 9 13:59:18 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit 0076c28 Author: Dan Q <dan@danq.me> Date: Tue Aug 8 07:59:42 2023 +0100 Update plugins/woocommerce-admin/client/marketplace/components/feedback-modal/feedback-modal.tsx commit 05f1606 Author: Dan Q <dan@danq.me> Date: Tue Aug 8 07:58:36 2023 +0100 Fixed merge commit b73a324 Merge: df92adf a807040 Author: Dan Q <danq@automattic.com> Date: Tue Aug 8 07:56:33 2023 +0100 Merge branch 'feature/marketplace' into add/wccom-17602-marketplace-feedback-component commit df92adf Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:53:17 2023 +0100 i18n: make "Additional thoughts" translatable commit b043355 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:36:41 2023 +0100 Add feedback modal to content commit deae2e6 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 10:33:43 2023 +0100 Validation/validation feedback on likert scales commit 50aadee Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:27:48 2023 +0100 Remove unused props commit 928a62d Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:27:15 2023 +0100 Don't ask for feedback if dismissed earlier today commit 9a8b896 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:16:18 2023 +0100 Enable suppression by multiple dismissal or by submission commit 521181a Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 09:01:26 2023 +0100 Add a max date This is important because we don't want to ask for feedback on a "new" marketplace forever, and we can't necessarily rely on being able to remove the dialog in a future version of WooCommerce (because some users might never upgrade beyond this version). commit 0f36d36 Author: Dan Q <danq@automattic.com> Date: Mon Aug 7 08:47:04 2023 +0100 Removed email field commit b83ca81 Author: Dan Q <danq@automattic.com> Date: Fri Aug 4 12:18:54 2023 +0100 CES push from feedback form commit e5b6e5b Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 16:33:55 2023 +0100 Hook up events. Fix a11y (keyboard navigation). commit b679495 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 15:49:24 2023 +0100 Initial icon in snackbar commit b702be9 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 15:23:16 2023 +0100 Use a snackbar notice to open the feedback modal commit 06736e4 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 14:25:35 2023 +0100 Feedback modal design matching commit 7c3a969 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:40:35 2023 +0100 Basic layout of Likert scales on feedback component commit 3c3f0e0 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:25:15 2023 +0100 Tidier order of likert items commit 8176e88 Author: Dan Q <danq@automattic.com> Date: Tue Aug 1 13:21:52 2023 +0100 Initial skeleton for WooCommerce Marketplace/Extensions feedback component commit 62a4bfa Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Thu Jul 27 15:47:54 2023 +0300 👌 Use admin theme color for select2 commit 2681177 Author: Nathan Silveira <nsschneider1@gmail.com> Date: Fri Jul 28 14:40:18 2023 -0300 [ Product Block Editor ] Create Variation options block (#39256) * Add support for variable products * Add 'hello world' block to variations tab * Add product-section block to template * Add AttributeControl component to screen * Add changelog * Change labels * Make a copy of AttributeControl to VariationOptionsControl to allow the fields to evolve separately in future * Fix tests * Add changelog to woocommerce * Fix alert error * Remove copied control and start adapting attribute control to handle both scenarios * Add -field to block name * Revert "Add -field to block name" This reverts commit 50e1ee6. * Revert "Revert "Add -field to block name"" This reverts commit eee0441. * Extract more labels * Hide drag handle in variation options commit 575bbae Author: Nathan Silveira <nsschneider1@gmail.com> Date: Fri Jul 28 14:05:03 2023 -0300 [Product Block Editor] Add require password block field (#39464) * Add post password to API * Add changelog * Fix phpcs issue * Remove post_password from tests * Add additional property to test * Increment number of properties in product schema * Update the post when post_password changes * Start adding password block * Add css and import it * Refactor attributes and erase password when checkbox is unchecked * Add changelogs * Remove unused imports * Rename 'fields' to 'field' * Refactor CSS * Remove example object commit bb390b1 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Thu Jul 27 15:18:10 2023 -0700 Update template version commit 87ae3d1 Author: github-actions <github-actions@github.com> Date: Thu Jul 20 19:12:38 2023 +0000 Add changefile(s) from automation for the following project(s): woocommerce commit 9c7c58c Author: Chris McNeill <82999806+csmcneill@users.noreply.github.com> Date: Thu Jul 20 13:53:07 2023 -0500 Removes the "for your state" string from the checkout page if there are no current payment methods available. commit d4893c4 Author: Paul Sealock <psealock@gmail.com> Date: Fri Jul 28 11:10:29 2023 +1200 Monorepo Utils: Fix no merge base in changefile script (#39467) * when checking out remote branch, ensure git history is there to find common ancestor for git diff * remove unshallow commit 144e873 Author: Leif Singer <leif@automattic.com> Date: Thu Jul 27 22:29:59 2023 +0200 Optimize system status tests (#39363) commit fccc62d Author: Nathan Silveira <nsschneider1@gmail.com> Date: Thu Jul 27 13:02:36 2023 -0300 [Product Block Editor] Add post_password parameter to the Woo product REST api (#39438) * Add post password to API * Add changelog * Fix phpcs issue * Remove post_password from tests * Add additional property to test * Increment number of properties in product schema * Update the post when post_password changes commit cb787ab Author: Leif Singer <leif@automattic.com> Date: Thu Jul 27 14:06:55 2023 +0200 Shard unit test runs (#39362) commit d7e5703 Author: Jorge Torres <jorge.torres@automattic.com> Date: Tue Jul 25 11:25:49 2023 -0300 Add changelog commit 8cf45dc Author: Jorge Torres <jorge.torres@automattic.com> Date: Tue Jul 25 11:25:29 2023 -0300 Include postcode in Vietnam address format commit 527701f Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 18 10:55:32 2023 +0300 Update count color, use admin theme commit 35c1592 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 15:10:29 2023 +0300 Update helper css to use admin theme color commit bf95490 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 14:06:54 2023 +0300 Changelog commit eb7b83b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:52:50 2023 +0300 Hover on orders view icon, use admin theme color commit 378d005 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:51:49 2023 +0300 Store alerts update - use admin theme colors commit 603cbd3 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Fri Jul 14 13:50:02 2023 +0300 Components empty content icon color commit 3c9e460 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 16:34:49 2023 +0300 Finally, that's the changelog :) commit 8f40038 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 16:16:28 2023 +0300 Changelog commit 016ae26 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:43:45 2023 +0300 Changelog (again) commit df07d17 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:24:18 2023 +0300 Changelog commit 30f4380 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:09:15 2023 +0300 Remove styles from buttons, as theme colors.css is taking care of them commit 5497cef Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Wed Jul 12 15:01:36 2023 +0300 Applied review comments commit 57d4f68 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:43:05 2023 +0300 Remove hardcoded text color wherever variable background color is used commit ea19b23 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:21:37 2023 +0300 Fix activation css to use wp-admin-theme-color commit dbffd6b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 19:04:49 2023 +0300 Use new branding colors in activation and wc setup commit 68a83a0 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 17:45:39 2023 +0300 Shipping methods empty state follow theme colors (and minor improvements) commit 366ee82 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:43:39 2023 +0300 Use page-title-action instead of deprecated add-new-h2 commit f62221c Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:43:09 2023 +0300 Untested extensions modal uses theme colors commit 4bd8f6b Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:41:10 2023 +0300 Auth page uses Woo colors, according to branding commit e637035 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:40:41 2023 +0300 Importer/Exporter use admin theme color commit 6a76fd7 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:38:18 2023 +0300 Breadcrump up link use admin theme color commit 1b67a7f Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:37:15 2023 +0300 Email status use admin theme color commit 3b69ad1 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:35:20 2023 +0300 Input toggles use admin theme color commit b9cd91c Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:34:56 2023 +0300 WooCommerce message use admin theme color commit 5c1dfad Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:34:24 2023 +0300 Blankstate buttons follow theme colors commit 20d9981 Author: Panos (Panagiotis) Synetos <2484390+PanosSynetos@users.noreply.github.com> Date: Tue Jul 11 16:24:57 2023 +0300 Change default WooCommerce color commit 16d295d Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Tue Jul 25 11:07:52 2023 -0700 Use the LegacyProxy to invoke get_plugins, remove CodeHacking usage commit 5c0d161 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Fri Jun 23 15:27:55 2023 -0700 Add changelog file commit 28e4ce9 Author: Corey McKrill <916023+coreymckrill@users.noreply.github.com> Date: Fri Jun 23 15:23:42 2023 -0700 WC Tracker: Add unit test for plugin feature compat data In #38849 a change was made that allowed the class mocking necessary for this test to happen in a way that wouldn't interfere with other unit tests. Fixes #38720 commit f479625 Author: Sam Seay <samueljseay@gmail.com> Date: Wed Jul 26 12:54:45 2023 +0800 WooCommerce Docs: Fix a bug where passing full file urls made ids unstable. (#39357) Fix a bug where passing full file urls made ids unstable. commit ce79211 Author: Vedanshu Jain <vedanshu.jain.2012@gmail.com> Date: Tue Jul 25 18:00:03 2023 +0530 Support inserting NULL values for strict DB mode (#39396) * Support inserting NULL values for strict DB mode * Set default date for placeholder order to support strict MySQL. * Add unit test to verify strict mode also works. * Make HPOS behavior of modified date consistent with WP_Post. In HPOS we were leaving modified date to be empty, while WP_Post set it to the created date if modified date is null. commit b1cb905 Author: Paul Sealock <psealock@gmail.com> Date: Tue Jul 25 15:29:43 2023 +1200 WooCommerce Docs: Handle multiple category posts (#39352) commit ddf9a77 Author: Paul Sealock <psealock@gmail.com> Date: Tue Jul 25 10:03:01 2023 +1200 Monrepo Utils code-freeze: Update version bump to modify release branches (#39243) commit 91a0fba Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Jul 24 14:21:47 2023 -0500 Delete changelog files based on PR 39327 (#39388) Delete changelog files for 39327 Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com> commit 8ae03a5 Author: Moon <moon.kyong@automattic.com> Date: Tue Jul 25 04:13:13 2023 +0900 Update/39325 typo in core profiler data sharing copy (#39327) * Fix grammar in data-sharing agreement copy * Add changelog * Put , * Add brackets * Move learn more link inside the bracket * Update test snapshot * Fix grammar * Update test snapshot commit 41d052b Author: RJ <27843274+rjchow@users.noreply.github.com> Date: Mon Jul 24 20:34:38 2023 +0800 dev: core profiler pages storybook (#39046) * dev: core profiler pages storybook * changed css path to pre-build zip path commit c119d8f Author: Rodel Calasagsag <rodel.calasagsag@automattic.com> Date: Thu Jul 20 09:30:43 2023 +0800 Add changelog commit 598adeb Author: Rodel Calasagsag <rodel.calasagsag@automattic.com> Date: Wed Jul 19 18:56:39 2023 +0800 Fix flakiness commit 8f14d89 Author: Jon Lane <jon.lane@automattic.com> Date: Fri Jul 21 13:22:07 2023 -0700 Skip tax rates test if CI commit b7913a7 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 15:50:50 2023 -0700 Changelog commit 4c3ef8e Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 15:49:02 2023 -0700 Skip failing tests commit c3e7652 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:28:40 2023 -0700 Update config to use API URL commit 149c969 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:26:59 2023 -0700 Update API URL in workflow and run all API tests commit be992dc Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:22:04 2023 -0700 Run global setup commit 00f55c3 Author: Jon Lane <jon.lane@automattic.com> Date: Thu Jul 20 14:20:36 2023 -0700 Perform a site reset if running on CI commit b128f07 Author: Sam Seay <samueljseay@gmail.com> Date: Sat Jul 22 12:22:55 2023 +0800 WooCommerce Docs: Add support for more core block conversion (#39244) * WIP extend support for frontmatter in manifests. * Change some of the prop names in the frontmatter support, add tests. * WIP support new frontmatter in plugin. * Improve category processing. * restructure the docs to have a nested category with no index. * Add WP test stubs to dev. * Add tests for the ManifestProcessor. * Add param docs to function * Store post meta on posts when they are updated or created. Add supporting tests. * WIP supporting more core block types. * Fix bugs in conversion. * Adjust conversion for issues with tables, blockquotes, code. * Resolve pnpm lock conflicts * Return manifest to state in trunk. * Return pnpm lock to trunk state. * Update fixture for new md content. commit 0243bfd Merge: 19ba93c 34e490f Author: And Finally <andfinally@users.noreply.github.com> Date: Wed Jul 26 14:03:25 2023 +0100 Add new top admin bar to marketplace (#39145) commit 34e490f Author: And Finally <andfinally@users.noreply.github.com> Date: Wed Jul 26 12:31:59 2023 +0100 Tidying history for #39145. Copied changes from `add/wccom-17419-marketplace-top-admin-bar`. Deleting unused import. Addressing CSS linter errors. commit 19ba93c Merge: 30e23d2 28cb100 Author: Kyle Nel <22053773+kdevnel@users.noreply.github.com> Date: Wed Jul 26 12:52:39 2023 +0200 Setup marketplace React skeleton layout (#39382) commit 28cb100 Author: Kyle Nel <22053773+kdevnel@users.noreply.github.com> Date: Tue Jul 4 14:08:50 2023 +0200 Add skeleton and cherry-picked commits - Reset layout to allow full width - Added Footer & IconWithText components Add temporary placeholder components All components here are temporary and can be removed/replaced when their relevant PR is ready. Add marketplace footer component The component is added using a SlotFill to use the existing WC Admin footer and utilise full width correctly. Setup initial content area layout Update tab styles Setup styling to match latest design Finalise footer, wide layout, and tidy styles - Applies the wide layout from latest MVP design - Applies the correct footer links to titles - Some general style tidying Organise styles and setup variables Swap to using CSS Grid for layouts Update breakpoints Restructure style naming and update to core styles Add translation in some places In-app marketplace search component. Cleaned up the commit history of this branch. Copied changes from these commits: e982842 9ca2ae3 e478157 976811c 46eafdf Deleted unused import. commit 30e23d2 Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Jul 20 17:00:22 2023 +0100 Changed `Tabs` to use `useQuery` instead of `getQuery`, so the browser back button will work. Changed submenu item name back to `Extensions`, and keeping it in the current order within the WooCommerce menu. Changed `path` value to `extensions`. commit a2b878e Author: And Finally <andfinally@users.noreply.github.com> Date: Thu Jul 20 14:53:06 2023 +0100 First commit. This contains the changes from `update/react-marketplace`, reviewed in #38885. Addressing linter errors.

nathanss added 13 commits July 26, 2023 10:19

Add post password to API

4cc65d2

Add changelog

df49966

Fix phpcs issue

6d4d2e1

Remove post_password from tests

d117ba6

Add additional property to test

f14621f

Increment number of properties in product schema

454fa26

Update the post when post_password changes

61065ed

Start adding password block

0f9e3e0

Add css and import it

15826c5

Refactor attributes and erase password when checkbox is unchecked

c7c1f40

Merge branch 'trunk' into add/post_password_block2

2cfc1e1

Add changelogs

4e4c497

Remove unused imports

252c01f

github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 27, 2023

nathanss self-assigned this Jul 27, 2023

mattsherman requested changes Jul 28, 2023

View reviewed changes

nathanss added 3 commits July 28, 2023 12:36

Rename 'fields' to 'field'

8a12f4b

Refactor CSS

a30442d

Remove example object

8a58a6e

mattsherman approved these changes Jul 28, 2023

View reviewed changes

nathanss merged commit bf97630 into trunk Jul 28, 2023
23 checks passed

nathanss deleted the add/post_password_block2 branch July 28, 2023 17:05

github-actions bot added this to the 8.1.0 milestone Jul 28, 2023

github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jul 28, 2023

lanej0 added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jul 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Product Block Editor] Add require password block field #39464

[Product Block Editor] Add require password block field #39464

nathanss commented Jul 27, 2023

github-actions bot commented Jul 27, 2023 •

edited

mattsherman left a comment

mattsherman Jul 28, 2023

mattsherman Jul 28, 2023

mattsherman Jul 28, 2023

mattsherman left a comment

[Product Block Editor] Add require password block field #39464

[Product Block Editor] Add require password block field #39464

Conversation

nathanss commented Jul 27, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

github-actions bot commented Jul 27, 2023 • edited

Test Results Summary

mattsherman left a comment

Choose a reason for hiding this comment

mattsherman Jul 28, 2023

Choose a reason for hiding this comment

mattsherman Jul 28, 2023

Choose a reason for hiding this comment

mattsherman Jul 28, 2023

Choose a reason for hiding this comment

mattsherman left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 27, 2023 •

edited