Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E test coverage]: Disable block product editor #39493

Merged
merged 46 commits into from Aug 8, 2023

Conversation

octaedro
Copy link
Contributor

@octaedro octaedro commented Jul 31, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR introduces E2E tests to ensure that disabling the new experience works as expected.

Closes #39417.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Execute the standard commands to launch the local E2E environment.
  2. Make sure the test is not flaky by running multiple instances of it repeatedly. You can do so through this command:
    cd plugins/woocommerce
    pnpm test:e2e-pw disable-block-product-editor.spec.js --retries=0 --workers=4 --repeat-each=8
  3. All instances of this test should pass, which indicates it isn't flaky.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jul 31, 2023
@octaedro octaedro changed the base branch from trunk to add/39442_enable_block_product_editor July 31, 2023 17:24
@octaedro octaedro self-assigned this Jul 31, 2023
@octaedro octaedro requested a review from a team July 31, 2023 17:26
@octaedro octaedro marked this pull request as ready for review July 31, 2023 17:27
@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Hi @lanej0, @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Test Results Summary

Commit SHA: 07cd6f3

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 54s
E2E Tests1950015021016m 48s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@octaedro octaedro changed the base branch from add/39442_enable_block_product_editor to trunk August 1, 2023 02:36
@octaedro octaedro force-pushed the add/39417_disable_block_product_editor branch from d3640f5 to 9dc3b15 Compare August 1, 2023 02:45
@octaedro octaedro changed the base branch from trunk to add/39442_enable_block_product_editor August 1, 2023 11:49
@octaedro octaedro force-pushed the add/39442_enable_block_product_editor branch from 02d204d to 7b17883 Compare August 4, 2023 17:22
@octaedro octaedro force-pushed the add/39417_disable_block_product_editor branch from 9dc3b15 to 05af057 Compare August 4, 2023 17:49
@octaedro octaedro changed the base branch from add/39442_enable_block_product_editor to trunk August 4, 2023 18:45
@octaedro octaedro force-pushed the add/39417_disable_block_product_editor branch from d15f100 to eb1e9af Compare August 8, 2023 18:23
Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lanej0 lanej0 merged commit 8f147ea into trunk Aug 8, 2023
23 checks passed
@lanej0 lanej0 deleted the add/39417_disable_block_product_editor branch August 8, 2023 22:36
@github-actions github-actions bot added this to the 8.1.0 milestone Aug 8, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 8, 2023
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[E2E test coverage]: Disable block product editor
3 participants