Prevent possible fatal error when user holds edit lock for a deleted order

[jorgeatorres]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

With HPOS enabled, if an order gets deleted while being edited in a different browser window/session, a fatal error is logged when the AJAX heartbeat attempts to refresh the edit lock. This doesn't have any serious implication, other than an error being logged, but better to not produce it at all ("silence is golden").

Closes #39354.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. On the admin, create an order and open it for editing. Do not close this browser tab.
2. Open a new browser tab and go to WC > Orders.
3. Check off the checkbox next to the order from step 1.
4. Choose "Move to trash" in the bulk actions dropdown and click "Apply".
5. Go to the Trash and empty it (or permanently delete the order).
6. Go back to the browser tab from step 1.
7. Wait a few minutes (with the tab open) for a "heartbeat" request to come through.
   You can use the dev tools to monitor for such XHR request.
8. Confirm that:
   • On trunk, a PHP critical error is logged:

     CRITICAL Uncaught Error: Call to a member function get_type() on bool in /.../woocommerce/src/Internal/Admin/Orders/EditLock.php:103
     

   • On this branch, no error is triggered.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 64e716e

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 17s
E2E Tests	189	0	0	19	0	208	17m 25s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[coreymckrill]

👍 I setup logging to use WC_Log_Handler_DB and confirmed that with this branch, the fatal error no longer occurs when the heartbeat can't find the order it's tracking.