Update/79113 incorrect subheading style and copy on wc core profiler

[moon0326]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes Automattic/wp-calypso#79113

How to test the changes in this Pull Request:

1. Checkout this branch and build the assets.
2. Start the core profiler.
3. Confirm subheading letter-spacing is 0

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Hi @chihsuan, @adrianduffell, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Test Results Summary

Commit SHA: c8a9423

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 11s
E2E Tests	189	0	0	19	0	208	13m 44s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[chihsuan]

@moon0326 Thanks for the fix!

I'm not sure if we want to update the subheading style in the Core. I thought we wanted to fix it on Jetpack connect page since @verofasulo identified this style bug on Jetpack connect page.

Besides, I checked the CSS styles, and I noticed that letter-spacing difference. Core's letter-spacing is 0.25px. Could you also update it? 🙏

[verofasulo]

Core's letter-spacing is 0.25px.

@moon0326, where do you see this? Letter spacing should be 0px both for body and heading 😅

[moon0326]

Core's letter-spacing is 0.25px.

@moon0326, where do you see this? Letter spacing should be 0px both for body and heading 😅

@verofasulo Subheadings have 0.25px letter spacing

0.25px:

0px:

[moon0326]

@moon0326 Thanks for the fix!

I'm not sure if we want to update the subheading style in the Core. I thought we wanted to fix it on Jetpack connect page since @verofasulo identified this style bug on Jetpack connect page.

Besides, I checked the CSS styles, and I noticed that letter-spacing difference. Core's letter-spacing is 0.25px. Could you also update it? 🙏

@chihsuan Ah..gotcha :) I'll open a new PR in wp-calypso 👍

Updated letter-spacing in 2c893d0

[chihsuan]

Thanks @moon0326 LGTM and tested well. 👍

I think it's okay to merge this PR with just one approval.