New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin installation request track for core profiler #39533
Conversation
Hi @chihsuan, @moon0326, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
recordEvent( 'coreprofiler_store_extensions_continue', { | ||
shown: event.payload.pluginsShown || [], | ||
selected: event.payload.pluginsSelected || [], | ||
unselected: event.payload.pluginsUnselected || [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though it's possible to infer some values, we have both selected and unselected so that it's easy to query in analytics.
Test Results SummaryCommit SHA: 1a0ab2b
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well. 👍
can you build funnels with nested properties?
and split on shown.jetpack == true, etc? I'm thinking it would be quite troublesome to do funnel analysis with the comma separated tuple sets alternatively, maybe
|
@rjchow I think your alternative proposal might make it possible to make some limited analysis with tracks funnel, where not possible with the current design. However, I'm unsure:
@moon0326 Do you have any opinion on whether using slightly different prop structure for this track? |
Sorry for the delay 🙏
WIth my limited experience with funnel, what about we use the following name pattern?
jetpack_shown: true |
@moon0326 Edit: actually, plugin slugs are not valid for track prop name since there's dashes, i.e: |
…-plugins-step-tracks
As long as it satisfies the needs of whoever might use it, I'm not hung up about it 😆 |
…-plugins-step-tracks
* Add track to plugin installation in core profiler * Rename available to shown * Add changelog * Lint
Changes proposed in this Pull Request:
Closes #39484.
This PR adds the track
wcadmin_coreprofiler_store_extensions_continue
with propsshown
,selected
, andunselected
when a user clicks on continue in the plugins step in core profiler.shown
are plugins that are shown to the user whether it's installed & activated or notselected
are plugins that are selectedunselected
are plugins that are unselectedHow to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
localStorage.setItem( 'debug', 'wc-admin:*' );
to set debug for tracks.Onboarding wizard > Business Info
step (/wp-admin/admin.php?page=wc-admin&path=%2Fsetup-wizard&step=business-info
)Afghanistan
as the store country to have limited pluginsContinue
Continue
Continue
Changelog entry
Significance
Type
Message
Comment