Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolbar button text not showing in WP 6.3 #39572

Merged
merged 2 commits into from Aug 4, 2023
Merged

Fix toolbar button text not showing in WP 6.3 #39572

merged 2 commits into from Aug 4, 2023

Conversation

joshuatf
Copy link
Contributor

@joshuatf joshuatf commented Aug 3, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Gutenberg recently updated toolbar items to use Ariakit instead of Reakit. This PR removed the children prop from the render of toolbar items.

I think it's likely that this is unexpected behavior, so I'll open an issue and fix upstream, but in the meantime this is a workaround that allows buttons to work.

Screen Shot 2023-08-03 at 1 29 12 PM

Closes #39543 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the new product editing experience under WooCommerce -> Settings -> Advanced -> Features.
  2. Navigate to the Add Product page.
  3. Click on "Add description"
  4. Note that the "Cancel" and "Done" buttons and text are visible in the modal toolbar
  5. Update to WP 6.3
  6. Check that the buttons and text are still visible in the description modal toolbar

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@joshuatf joshuatf added the release: cherry-pick Commits from this PR also needs to be added to current release branch. label Aug 3, 2023
@joshuatf joshuatf requested a review from a team August 3, 2023 20:30
@joshuatf joshuatf self-assigned this Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023 •
edited

Test Results Summary

Commit SHA: 2fa8b43

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 59s
E2E Tests1890019020817m 55s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

octaedro
octaedro approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @joshuatf for the quick fix. This is testing well here and code LGTM 🚀

@jonathansadowski jonathansadowski added this to the 8.0.0 milestone Aug 4, 2023
@jonathansadowski jonathansadowski merged commit 63ca33a into trunk Aug 4, 2023
23 checks passed
@jonathansadowski jonathansadowski deleted the fix/39543 branch August 4, 2023 21:23
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 4, 2023
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 4, 2023
@joshuatf
Fix toolbar button text not showing in WP 6.3 (#39572)
a85da3c 
* Fix toolbar button text not showing in WP 6.3

* Add changelog entry
jonathansadowski pushed a commit that referenced this pull request Aug 4, 2023
@github-actions @joshuatf
Cherry pick 39572 into release/8.0 (#39594)
82076c1 
Fix toolbar button text not showing in WP 6.3 (#39572)

* Fix toolbar button text not showing in WP 6.3

* Add changelog entry

Co-authored-by: Joshua T Flowers <joshuatf@gmail.com>
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Aug 7, 2023
tommyshellberg pushed a commit that referenced this pull request Aug 7, 2023
@joshuatf @tommyshellberg
Fix toolbar button text not showing in WP 6.3 (#39572)
43ad76b 
* Fix toolbar button text not showing in WP 6.3

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octaedro octaedro octaedro approved these changes

Assignees

@joshuatf joshuatf

Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. release: cherry-pick Commits from this PR also needs to be added to current release branch. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Milestone
8.0.0
4 participants
@joshuatf @octaedro @jonathansadowski @rodelgc