Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/refactor core profiler utils #39581

Merged
merged 3 commits into from Aug 15, 2023
Merged

Conversation

rjchow
Copy link
Contributor

@rjchow rjchow commented Aug 4, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

  • dev: added useFullScreen hook
  • dev: made findComponentMeta generic

How to test the changes in this Pull Request:

This is a pure refactoring that extracts some common functionality in core profiler into utilities.
There should be no user facing changes.

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Brief smoke test to check that the core profiler still renders should be sufficient, the only functionality that was touched is the fullscreening utility

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Test Results Summary

Commit SHA: 202c34f

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 2s
E2E Tests1890019020814m 24s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@rjchow rjchow force-pushed the dev/refactor-core-profiler-utils branch from 5f25c71 to 202c34f Compare August 7, 2023 12:17
@rjchow rjchow marked this pull request as ready for review August 8, 2023 13:30
@rjchow rjchow requested review from a team, ilyasfoo and chihsuan August 8, 2023 13:32
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Hi @ilyasfoo, @chihsuan, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! LGTM and confirmed everything still works. 🚢

For reviewers, I think JN live branche feature is not working due to the WC Blocks bug. But I found that we can install and activate WooCommerce Blocks plugin to fix it.

@rjchow
Copy link
Contributor Author

rjchow commented Aug 15, 2023

merging with 1 review since it's pretty trivial

@rjchow rjchow merged commit 964dd1f into trunk Aug 15, 2023
27 checks passed
@rjchow rjchow deleted the dev/refactor-core-profiler-utils branch August 15, 2023 11:26
@github-actions github-actions bot added this to the 8.1.0 milestone Aug 15, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 15, 2023
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants