New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev/refactor core profiler utils #39581
Conversation
Test Results SummaryCommit SHA: 202c34f
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
- foresee using this in more developments
5f25c71
to
202c34f
Compare
Hi @ilyasfoo, @chihsuan, @woocommerce/ghidorah Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! LGTM and confirmed everything still works. 🚢
For reviewers, I think JN live branche feature is not working due to the WC Blocks bug. But I found that we can install and activate WooCommerce Blocks plugin to fix it.
merging with 1 review since it's pretty trivial |
Submission Review Guidelines:
Changes proposed in this Pull Request:
How to test the changes in this Pull Request:
This is a pure refactoring that extracts some common functionality in core profiler into utilities.
There should be no user facing changes.
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment