Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/default payments gateways recommendations #39635

Merged
merged 4 commits into from Mar 8, 2024

Conversation

vladolaru
Copy link
Contributor

@vladolaru vladolaru commented Aug 9, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR updates the default payment gateway recommendation priority to match the per-country recommendations and order in this spreadsheet.

Note: I followed the lead of #37442.

How to test the changes in this Pull Request:

Review the changes and make sure the order aligns with this spreadsheet

  1. Go to OBW and select US as store country
  2. Complete OBW with WCPay installed
  3. Go to /wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com
  4. Untick Display suggestions within WooCommerce
  5. Go to WooCommerce > Home > Payment task
  6. Set up the WCPay
  7. Go to WooCommerce > Home > AdditionalPayments task
  8. Observe that payment gateways are shown in the following order:
  • PayPal
  • AmazonPay
  • Affirm
  • Afterpay
  • Klarna
  • Zip Co

  1. Change store country to Germany
  2. Go to AdditionalPayments task
  3. Observe that payment gateways are shown in the following order:
  • PayPal
  • Klarna Payments
  • AmazonPay

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@vladolaru vladolaru self-assigned this Aug 9, 2023
@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Test Results Summary

Commit SHA: 3524a15

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 38s
E2E Tests268008303517m 20s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@elazzabi elazzabi marked this pull request as ready for review March 7, 2024 15:56
Copy link
Contributor

@elazzabi elazzabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-checked the order provided with the documentation. Looks good 👍

@elazzabi elazzabi merged commit ebd54a7 into trunk Mar 8, 2024
33 of 34 checks passed
@elazzabi elazzabi deleted the update/default-payments-gateways-recommendations branch March 8, 2024 19:24
@github-actions github-actions bot added this to the 8.8.0 milestone Mar 8, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Mar 8, 2024
@alopezari alopezari added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Mar 11, 2024
Konamiman pushed a commit that referenced this pull request Mar 13, 2024
* Update default gateways recommendations

* Add changelog entry

* Add Airwallex where missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants