Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the new editor for variable products. #39780

Merged
merged 2 commits into from Aug 18, 2023
Merged

Conversation

AnnaMag
Copy link
Contributor

@AnnaMag AnnaMag commented Aug 17, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

The new editor should only be available for simple products. Here, we only include the visibility of the variable variant if the relevant dev feature flag enabled.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Disable the product-variation-management feature flag
  2. Go to the task list and verify that the new editor works for Physical products and NOT for the Variable ones.
  3. Enable the product-variation-management feature flag
  4. Complete 2. where now both products types open the new editor
  5. Verify that you can open an existing variable product in the new editor.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Aug 17, 2023
@github-actions
Copy link
Contributor

Hi @louwie17, @mdperez86, @nathanss,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@AnnaMag AnnaMag added focus: product management Related to product creation and editing. team: Mothra focus: new product ux revamped product management experience and removed focus: product management Related to product creation and editing. labels Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

Test Results Summary

Commit SHA: 596c404

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 13s
E2E Tests1950015021018m 20s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Tested well.
Only thing missing is a changelog @AnnaMag

@AnnaMag AnnaMag requested a review from louwie17 August 18, 2023 07:40
Copy link
Contributor

@louwie17 louwie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving with the addition of the changelog :shipit:

@louwie17 louwie17 merged commit afc8e0f into trunk Aug 18, 2023
26 checks passed
@louwie17 louwie17 deleted the fix/new-editor-exposure branch August 18, 2023 12:26
@github-actions github-actions bot added this to the 8.1.0 milestone Aug 18, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 18, 2023
@lanej0 lanej0 added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Aug 18, 2023
samueljseay pushed a commit that referenced this pull request Aug 23, 2023
* Disable the new editor for variable products with the dev feature flag disabled.

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Mothra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants