New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the new editor for variable products. #39780
Conversation
Hi @louwie17, @mdperez86, @nathanss, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 596c404
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Tested well.
Only thing missing is a changelog @AnnaMag
261b170
to
596c404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving with the addition of the changelog
* Disable the new editor for variable products with the dev feature flag disabled. * Add changelog
Submission Review Guidelines:
Changes proposed in this Pull Request:
The new editor should only be available for simple products. Here, we only include the visibility of the variable variant if the relevant dev feature flag enabled.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
product-variation-management
feature flagproduct-variation-management
feature flagChangelog entry
Significance
Type
Message
Comment