Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Block Editor] remove digital products from target list #39801

Merged
merged 2 commits into from Aug 18, 2023

Conversation

octaedro
Copy link
Contributor

@octaedro octaedro commented Aug 17, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR addresses the issue concerning the redirection to the new editor after selecting the option "Digital product".

Before
Screen Capture on 2023-08-17 at 18-02-42

A digital product object is an instance of a WC_Product_Simple class.
At the moment, the editor should only be shown for Physical products.

Closes #39769.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Enable the new editor.
  2. Visit the task list at the Add products stage.
  3. Select a Digital product.
  4. Confirm that the redirection leads to the old editor rather than the new editor.
  5. Return to step 2 and this time select a Simple product.
  6. You should now be redirected to the new editor.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added focus: react admin [team:Ghidorah] plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Aug 17, 2023
@octaedro octaedro requested a review from a team August 17, 2023 21:10
@octaedro octaedro self-assigned this Aug 17, 2023
@github-actions
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@octaedro octaedro marked this pull request as ready for review August 17, 2023 21:10
@github-actions
Copy link
Contributor

Test Results Summary

Commit SHA: 44067ce

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202611m 13s
E2E Tests1950015021023m 23s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@AnnaMag AnnaMag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@octaedro octaedro merged commit 5f7e20b into trunk Aug 18, 2023
31 checks passed
@octaedro octaedro deleted the fix/39769_remove_digital_products_from_target_list branch August 18, 2023 12:32
@github-actions github-actions bot added this to the 8.1.0 milestone Aug 18, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Aug 18, 2023
@lanej0 lanej0 added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Aug 18, 2023
samueljseay pushed a commit that referenced this pull request Aug 23, 2023
* Fix remove digital products from the target list

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Product Block Editor] remove digital products from the target list
3 participants