Update modified date when a metadata is saved for HPOS.

[vedanshujain]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

When using a $order->save_meta_data() method, we have a gap in our sync logic that we do not update the date_updated_gmt column. The consequence here is that it will become non-deterministic for code to figure whether posts or order is more updated when there is a difference between them. To prevent this, we also update the modified date when updating the metadata via save_metadata.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Note that we will be using wp shell to test this as it's not possible in the UI only to reproduce the bug.

1. Set HPOS as authoritative. Create a new order and note it's ID (or use an existing order with ID XXX).
2. Open a new wp shell and test following:

// Let's fetch the order 
$order = wc_get_order( XXX );

// Note it's current modified date
$order->get_date_modified();

// Add a new meta.
$order->add_meta_data( 'test1', 'new_value');
$order->save_meta_data();

// Note the current modified date, it should be updated.
$order->get_date_modified();

// Update the metadata.
$order->update_meta_data( 'test1', 'updated_value');
$order->save_meta_data();

// Note the current modified again, it should be updated
$order->get_date_modified();

// Delete the metadata
$order->delete_meta_data( 'test1' );
$order->save_meta_data();

// Note the current modified again, it should be updated
$order->get_date_modified();

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 9b10f04

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 20s
E2E Tests	195	0	0	15	0	210	14m 14s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @coreymckrill,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[coreymckrill]

👍 Works as described testing with wp shell. Noting that I also tested running $order->save_meta_data() without first adding/updating/deleting any meta data, and it did not change the date modified value, which is as expected.

[coreymckrill]

I was thinking that the call to current_time here should also have the 1 gmt switch, like above, but I guess that set_date_modified handles that already?