Escape the default "Thank you" text instead of the filtered message

[YordanSoares]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes #40329 and #40352

How to test the changes in this Pull Request:

1. Activate this code snippet in your site:

add_filter('woocommerce_thankyou_order_received_text', 'wc_test_thank_you_link', 10, 2);
function wc_test_thank_you_link( $text, $order ) {
    $text .= '<p><a href="https://example.com">Click here</a></p>';
    return $text;
}

2. Place a new order and check the code displayed after "Thank you. Your order has been received.", which should look like this:

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Escape the default 'thank you' text instead of the filtered message.

Comment

[github-actions]

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[lsinger]

Thanks @YordanSoares for your contribution! I left a comment for a linting directive we'll need. Could you also please bump the version of that template file to 8.3.0?

For the future to lint changes:

cd plugins/woocommerce
pnpm lint:php:changes

This would then at least detect the need for the directive.

[lsinger]

@YordanSoares It seems running the changelog adder doesn't currently work from forks. Could you run, from the root of the repository, the following to add a changelog file?

pnpm --filter=./plugins/woocommerce run changelog add

[YordanSoares]

@YordanSoares It seems running the changelog adder doesn't currently work from forks. Could you run, from the root of the repository, the following to add a changelog file?

pnpm --filter=./plugins/woocommerce run changelog add

@lsinger I tried to add this command, but it didn't work on my Windows environment:

I tried installing all the prerequisites, but I haven't being able to run it with success, yet. Any ideas?

[YordanSoares]

@lsinger it seems that @github-actions finally managed to log the change :)

[lsinger]

Thank you for making those changes, @YordanSoares! Looks good to me.

It seems the CI checks aren't running -- I'll try to close and re-open this PR to trigger them again.