Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new E2E tests to cover Shopper Mini Cart #40380

Merged
merged 2 commits into from Sep 25, 2023

Conversation

veljkho
Copy link
Contributor

@veljkho veljkho commented Sep 22, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

Closes # 30 in Woo Quality

Covered 6 out of 7 flows from the Mini Cart milestone. Left comment on remaining 1. The thing is that it seems impossible testing Taxes on Mini Cart because Taxes aren't present, there's a message telling customer that taxes are shown in the checkout.

Also commented 2 flows about Cannot View Mini Cart Block on Checkout Page and Cart Page, they are part of this PR but just as a simple test that mini cart's CSS is not present on pages cart and checkout.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Checkout this branch locally
  2. Execute the test: pnpm test:e2e-pw ./tests/e2e-pw/tests/shopper/mini-cart.spec.js --headed
  3. Optionally execute the whole test suite: pnpm test:e2e-pw
  4. Should be all green (passing)

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@veljkho veljkho self-assigned this Sep 22, 2023
@veljkho veljkho added the focus: e2e tests Issues related to e2e tests label Sep 22, 2023
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Test Results Summary

Commit SHA: 4899b7e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 55s
E2E Tests211007021818m 14s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@lanej0
Copy link
Contributor

lanej0 commented Sep 22, 2023

Hey @veljkho, not sure if this is still a work in progress or if it's ready for review. I did take a look at it, and one of the tests is failing for me:

Screenshot 2023-09-22 at 2 24 33 PM

@veljkho
Copy link
Contributor Author

veljkho commented Sep 23, 2023

Hi @lanej0
This task is done. I think it fails on your side because you have some Tax settings set (maybe you worked with some Tax tasks).

I will update this PR to ensure the settings are set properly for this flow.

@veljkho
Copy link
Contributor Author

veljkho commented Sep 25, 2023

@lanej0 Updated the test not to look for that tax label because for this test it is not really needed, instead improved to verify the price with 1 and 2 quantities. This way tax settings configuration doesn't conflict with the test.

Copy link
Contributor

@lanej0 lanej0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lanej0 lanej0 merged commit f9e05f6 into trunk Sep 25, 2023
26 checks passed
@lanej0 lanej0 deleted the e2e/add-new-tests-shopper-mini-cart branch September 25, 2023 22:29
@github-actions github-actions bot added this to the 8.3.0 milestone Sep 25, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Sep 25, 2023
@alopezari alopezari added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: e2e tests Issues related to e2e tests plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants