Fix: HPOS keeping disabled when the database tables were created via enabling the setting

[Konamiman]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

When the HPOS tables don't exist and are created on the fly by setting the new tables as authoritative (via the dedicated UI tool, or by setting the new tables as authoritative in setting), the setting wasn't changing and the posts table were still authoritative after the tables creation was completed. With the fix, this will be the case only when the creation of the tables fails.

Additionally:

• An error is logged if the tables can't be created, including the names of the affected tables.
• A minor bug in DatabaseUtil::parse_dbdelta_output is fixed (the returned table names had a ( appended at the end).

How to test the changes in this Pull Request:

Happy path

1. Make sure that the posts table is authoritative (via UI, in WooCommerce - Settings - Advanced - Features; or via command line, wp wc cot disable).
2. Go to WooCommerce - Status - Tools and run the "Delete the custom order tables" tool. Verify that the tables have been deleted (e.g. wp_wc_orders).
3. Change to the new tables as authoritative (via UI or via command line, wp wc cot enable).
4. Verify that the new tables have been recreated and that thet are indeed authoritative by reloading the settings page in UI (without the fix, the posts table will still be authoritative).

Error path

To test the error case you'll need to do some temporary changes to the code (there's no need to delete the tables this time, just apply these changes while the new tables are authoritative):

1. Remove/comment the first table of DataSyncrhonizer::create_database_tables (the one that invokes dbdelta).
2. Add the following at the end of the string returned by OrdersTableDataStore::get_database_schema:

CREATE TABLE wp_wc_foobar (id int);
CREATE TABLE wp_wc_fizzbuzz (id int);

Now try to set the new tables as authoritative with wp wc cot enable. You'll get a " [Failed] Orders table could not be created" error, the posts table will be authoritative now, and if you check the logs you'll see the following entry: ERROR HPOS tables are missing in the database and couldn't be created. The missing tables are: wp_wc_foobar, wp_wc_fizzbuzz.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Fix: HPOS keeping disabled when the database tables were created via enabling the setting

Comment

[github-actions]

Test Results Summary

Commit SHA: 98d923f

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	1m 19s
E2E Tests	212	0	0	7	0	219	20m 28s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @jorgeatorres,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[jorgeatorres]

@Konamiman: This is missing the changelog file. Other than that, it looks good to me. Thank you for working on this!

[Konamiman]

This is missing the changelog file.
I'm too used to it being generated automatically. It's added now.

[jorgeatorres]

LGTM. 🎉