-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mobile app onboarding modal to focus on app installation #40559
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0d62b35
Show mobile app installation QR code when the site is not Jetpack con…
jaclync 5b57f07
Simplify modal state by removing wrong user connected case and show t…
jaclync 367d6ef
Extract mobile installation view to a component, and show it in the i…
jaclync 6e7a54e
Remove redundant case when Jetpack is not installed/connected.
jaclync e4900d7
Rename app installation views to be consistent with the similar Jetpa…
jaclync fbd0ce2
Remove unused import.
jaclync 1235376
Add changelog.
jaclync 780c521
Increase the QR code dimension from 100x100 to 150x150 for better vis…
jaclync 1e454cf
Add `qrcode.react` for a React component that displays a QR code also…
jaclync 9a30b9a
Replace mobile static QR code SVG with `QRCodeSVG`.
jaclync 6a3a94e
Fit mobile app modal height to content with a max height that's talle…
jaclync File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
24 changes: 24 additions & 0 deletions
24
...ommerce-admin/client/homescreen/mobile-app-modal/components/MobileAppInstallationInfo.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { QRCodeSVG } from 'qrcode.react'; | ||
|
||
export const MobileAppInstallationInfo = () => { | ||
return ( | ||
<div> | ||
<QRCodeSVG | ||
value={ | ||
'https://woocommerce.com/mobile/?utm_source=wc_onboarding_mobile_task' | ||
} | ||
size={ 140 } | ||
/> | ||
<p> | ||
{ __( | ||
'Scan the code above to download the WooCommerce mobile app, or visit woocommerce.com/mobile from your mobile device.', | ||
'woocommerce' | ||
) } | ||
</p> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
plugins/woocommerce-admin/client/homescreen/mobile-app-modal/pages/MobileAppInstallPage.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import { ModalContentLayoutWithTitle } from '../layouts/ModalContentLayoutWithTitle'; | ||
import { MobileAppInstallationInfo } from '../components/MobileAppInstallationInfo'; | ||
|
||
export const MobileAppInstallPage = () => { | ||
return ( | ||
<ModalContentLayoutWithTitle> | ||
<MobileAppInstallationInfo /> | ||
</ModalContentLayoutWithTitle> | ||
); | ||
}; |
1 change: 1 addition & 0 deletions
1
plugins/woocommerce-admin/client/homescreen/mobile-app-modal/pages/index.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export { EmailSentPage } from './EmailSentPage'; | ||
export { JetpackAlreadyInstalledPage } from './JetpackAlreadyInstalledPage'; | ||
export { JetpackInstallStepperPage } from './JetpackInstallStepperPage'; | ||
export { MobileAppInstallPage } from './MobileAppInstallPage'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: update | ||
|
||
Updated the Woo mobile onboarding modal to focus on app installation. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll have to adjust the layout to fit the extra height
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm the screenshot seems to not have been uploaded, could you try uploading this again? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's so weird that it linked to this PR.. 😵
There's a scrollbar, indicating that the content has overflowed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I updated the styles in 6a3a94e so that this specific modal height fits to its content with a max height of 663px from my testing. Any other suggestions/improvements are welcome!