-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mobile app onboarding modal to focus on app installation #40559
Changes from 8 commits
0d62b35
5b57f07
367d6ef
6e7a54e
e4900d7
fbd0ce2
1235376
780c521
1e454cf
9a30b9a
6a3a94e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import MobileQRCode from '../illustrations/woo-mobile-download-qrcode.svg'; | ||
|
||
export const MobileAppInstallationInfo = () => { | ||
return ( | ||
<div> | ||
<img | ||
src={ MobileQRCode } | ||
alt={ __( 'Download WooCommerce mobile app', 'woocommerce' ) } | ||
width="150" | ||
/> | ||
<p> | ||
{ __( | ||
'Scan the code above to download the WooCommerce mobile app, or visit woocommerce.com/mobile from your mobile device.', | ||
'woocommerce' | ||
) } | ||
</p> | ||
</div> | ||
); | ||
}; |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -13,6 +13,7 @@ import { OPTIONS_STORE_NAME } from '@woocommerce/data'; | |||||
import { ModalContentLayoutWithTitle } from '../layouts/ModalContentLayoutWithTitle'; | ||||||
import { SendMagicLinkButton } from '../components'; | ||||||
import { SendMagicLinkStates } from '../components/useSendMagicLink'; | ||||||
import { MobileAppInstallationInfo } from '../components/MobileAppInstallationInfo'; | ||||||
|
||||||
interface JetpackAlreadyInstalledPageProps { | ||||||
wordpressAccountEmailAddress: string | undefined; | ||||||
|
@@ -58,12 +59,13 @@ export const JetpackAlreadyInstalledPage: React.FC< | |||||
return ( | ||||||
<ModalContentLayoutWithTitle> | ||||||
<> | ||||||
<MobileAppInstallationInfo /> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm the screenshot seems to not have been uploaded, could you try uploading this again? 🤔 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point! I updated the styles in 6a3a94e so that this specific modal height fits to its content with a max height of 663px from my testing. Any other suggestions/improvements are welcome!
|
||||||
<div className="modal-subheader jetpack-already-installed"> | ||||||
<h3> | ||||||
{ sprintf( | ||||||
/* translators: %s: user's WordPress.com account email address */ | ||||||
__( | ||||||
'We’ll send a magic link to %s. Open it on your smartphone or tablet to sign into your store instantly.', | ||||||
'After the app is installed, click below to send a magic link to %s. Open it on your smartphone or tablet to sign into your store instantly.', | ||||||
'woocommerce' | ||||||
), | ||||||
wordpressAccountEmailAddress | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** | ||
* Internal dependencies | ||
*/ | ||
import { ModalContentLayoutWithTitle } from '../layouts/ModalContentLayoutWithTitle'; | ||
import { MobileAppInstallationInfo } from '../components/MobileAppInstallationInfo'; | ||
|
||
export const MobileAppInstallPage = () => { | ||
return ( | ||
<ModalContentLayoutWithTitle> | ||
<MobileAppInstallationInfo /> | ||
</ModalContentLayoutWithTitle> | ||
); | ||
}; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export { EmailSentPage } from './EmailSentPage'; | ||
export { JetpackAlreadyInstalledPage } from './JetpackAlreadyInstalledPage'; | ||
export { JetpackInstallStepperPage } from './JetpackInstallStepperPage'; | ||
export { MobileAppInstallPage } from './MobileAppInstallPage'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: update | ||
|
||
Updated the Woo mobile onboarding modal to focus on app installation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SVG is somewhat sizeable but most of it should compress away over the wire. I think it would be good to also switch this over to the qrcode library when you work on the next iteration with dynamically generated QRs for the application password 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally I added the qrcode.react library in the next draft PR #40613, but I agree it's better to just start using the library also to minimize the diffs. Added in 1e454cf and 9a30b9a