Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use latest commit of stalebot action, tweak configuration accordingly #41305

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

rrennick
Copy link
Contributor

@rrennick rrennick commented Nov 8, 2023

Changes proposed in this Pull Request:

This PR updates stalebot to use the latest commit to main of the stalebot action. # 1033 adding caching to the stalebot action which allows it to continue processing from the previous run. Once it has processed all PRs/issue it resets and starts the scan from the first issue/PR.

Accordingly, this PR includes the following configuration changes:

  • replaces the 4 schedules with an hourly schedule
  • Reduces the number of items scanned to 100 per run

This should complete a scan of all open items within 24 hours. After the block merge the scan is likely to take closer to 28 hours which would be 6 complete scans every 7 days. This schedule should work fine for both scenarios.

A secondary benefit to this configuration change is it should allow adding a scan schedule for PRs once we have discussed a good time frame for this.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. YML review

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 8, 2023
@rrennick rrennick added focus: monorepo infrastructure Issues and PRs related to monorepo tooling. team: Solaris and removed plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Hi @ObliviousHarmony,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Test Results Summary

Commit SHA: d516d3b

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests243004024713m 25s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@ObliviousHarmony ObliviousHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that as per the documentation, operations-per-run is counting API calls rather than issues. Since processing an issue may require multiple API calls, it's possible for 100 operations to be more like 30 issues. An operations-per-run limit of 300 probably gets us closer to 100 issues per hour.

.github/workflows/stalebot.yml Show resolved Hide resolved
.github/workflows/stalebot.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 10, 2023
Copy link
Contributor

@ObliviousHarmony ObliviousHarmony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tolerating me @rrennick!

@jonathansadowski jonathansadowski merged commit 6402bf8 into trunk Nov 16, 2023
16 checks passed
@jonathansadowski jonathansadowski deleted the update/stalebot-action branch November 16, 2023 15:15
@github-actions github-actions bot added this to the 8.4.0 milestone Nov 16, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Nov 16, 2023
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants