Remove deprecated calls in class-wc-checkout.php #41567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$item->legacy_... result in "Something went wrong. Please contact us to get assistance." error message in the Cart block (PHP 8.2) PHP Deprecated: Creation of dynamic property WC_Order_Item_Product::$legacy_values is deprecated PHP Deprecated: Creation of dynamic property WC_Order_Item_Product::$legacy_cart_item_key is deprecated PHP Deprecated: Creation of dynamic property WC_Order_Item_Shipping::$legacy_package_key is deprecated
github-actions
bot
added
plugin: woocommerce
woocommercebot
requested review from
a team and
coreymckrill
and removed request for
a team
|
Hi , Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
|
|
There was a problem hiding this comment.
@tivnet Thanks for the PR. Even though these properties are "legacy" and have been deprecated, it seems like just removing them will probably cause something to break for someone without warning. A safer approach to eliminating those dynamic property notices might be to define these properties in the WC_Checkout class so they aren't dynamic anymore.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$item->legacy_... result in "Something went wrong. Please contact us to get assistance." error message in the Cart block (PHP 8.2)
PHP Deprecated: Creation of dynamic property WC_Order_Item_Product::$legacy_values is deprecated
PHP Deprecated: Creation of dynamic property WC_Order_Item_Product::$legacy_cart_item_key is deprecated
PHP Deprecated: Creation of dynamic property WC_Order_Item_Shipping::$legacy_package_key is deprecated