Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Marketplace subscriptions changelogs #41575

Merged

Conversation

kdevnel
Copy link
Contributor

@kdevnel kdevnel commented Nov 20, 2023

Changes proposed in this Pull Request:

We have been creating changelogs for each individual branch merged into the feature branch. When we merge the project, we should have a single changelog entry that covers all the work. This PR merges all the changelogs into a single one.

Closes https://github.com/Automattic/woocommerce.com/issues/18473

How to test the changes in this Pull Request:

  1. There is no local dev setup required - this is only a file change
  2. Check the plugins/woocommerce/changelogs folder changes
  3. There should be only a single file and all others we introduced should be removed.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@kdevnel kdevnel added focus: react marketplace Issues relating to the React Marketplace team: Fire labels Nov 20, 2023
@kdevnel kdevnel requested a review from a team November 20, 2023 11:01
@kdevnel kdevnel self-assigned this Nov 20, 2023
@kdevnel kdevnel requested review from bgrgicak and andfinally and removed request for a team November 20, 2023 11:01
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 20, 2023
Copy link
Contributor

Hi @bgrgicak, @andfinally,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@kdevnel kdevnel changed the base branch from trunk to feature/marketplace-subscriptions November 20, 2023 11:01
Copy link
Contributor

Test Results Summary

Commit SHA: 93459a9

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 39s
E2E Tests239215024714m 10s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.
  • INCOMPLETE E2E TEST RUN. We have a total of 248 E2E tests, but only 247 were executed. Note that in CI, E2E tests automatically end when they encounter too many failures.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@andfinally andfinally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Co-authored-by: And Finally <andfinally@users.noreply.github.com>
@kdevnel kdevnel merged commit 53b8933 into feature/marketplace-subscriptions Nov 21, 2023
5 checks passed
@kdevnel kdevnel deleted the update/wccom-18473-merge-changelogs branch November 21, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: react marketplace Issues relating to the React Marketplace plugin: woocommerce Issues related to the WooCommerce Core plugin. team: Fire
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants