Shipping Settings: Revert removal of default method names

[psealock]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

In #40838 default names for WooCommerce Shipping Zone methods was removed in favour of displaying a placeholder. In the case below e.g. Free shipping. The removal of the default is causing issues with previously configured methods that relied on there being a default.

It appears to have been a mistake to remove the default names of methods because systems interacting with shipping zone methods work under the assumption the default exists, and so this was a backwards incompatible change. This PR revert that changes and resets some unit and e2e tests back to their original state.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

1. Create a new JN site, but not from this branch. Make sure it includes the lastest WCX 8.3 release. You will see the old shipping zone method dialog which will allow you to enter a method without a name.
2. Add a shipping zone for the US, and add a free shipping method. Be sure to leave the name field as is.
3. Try adding a shippable product to the cart, and try to calculate shipping fees for an address in the US (it should work).
4. Now update WooCommerce to a zip of this branch. You can download it here.
5. Visit the shipping zone setting page, /wp-admin/admin.php?page=wc-settings&tab=shipping and see the "Shipping method(s)" column have names underneath.
6. Now go back to the checkout screen and refresh. You should see the shipping method available.
7. Finally, try adding a new shipping method. See the name field show the default values "Free shipping", "Flat rate", or "Local pickup" depending on the type.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

Fixes a bug found in unreleased feature. No changelog needed.

[github-actions]

Test Results Summary

Commit SHA: 2d8a192

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 35s
E2E Tests	256	0	0	6	0	262	18m 25s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi @chihsuan, @rodelgc, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @chihsuan, @rodelgc, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @chihsuan, @rodelgc, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[github-actions]

Hi @chihsuan, @rodelgc, @moon0326, @woocommerce/ghidorah

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[rjchow]

I wasn't able to test this because when I used WC 8.3.1, I saw the old shipping dialogs. If I use the live branch from the other PR, I'm also not allowed to leave the shipping method name empty

[psealock]

I wasn't able to test this because when I used WC 8.3.1, I saw the old shipping dialogs.

Yes, sorry I wasn't clear on this @rjchow. You will create the shipping zone method using the old UI in WC 8.3. This will allow you to enter a Shipping Method using the default value for "Name" field. Then, update to this branch's WC and confirm no errors exist.

If I use the live branch from the other PR, I'm also not allowed to leave the shipping method name empty

Indeed this is correct. The idea is to re-create a scenario where merchants would have created a method in the old dialog that has a default value, updated to the new, and seen errors due to missing "name" value.

[rjchow]

With the updated test instructions it seems to work fine! Thanks