New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product gallery: Enable block in blockified template and add transform from legacy one #42719
Conversation
Hi @danieldudzic, @thealexandrelara, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
1 similar comment
Hi @danieldudzic, @thealexandrelara, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 77e9e9f
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
b973aa7
to
639f460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to successfully test 1 & 2, but failed at the 3.
I tried multiple times, also utilizing (rm -rf **/.wireit
) but the new Product Gallery block would still be available in the transform for the deploy package. (I do blame it on the setup/caching issues though).
I'd potentially consider adding a transform to the Product Gallery to allow people to transform back to the legacy block, in case they want to revert the transformation.
@@ -11,6 +13,8 @@ import edit from './edit'; | |||
import metadata from './block.json'; | |||
import './style.scss'; | |||
|
|||
const galleryBlock = isExperimentalBuild() ? 'woocommerce/product-gallery' : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-picky: wouldn't productGalleryBlock
make more sense here?
Submission Review Guidelines:
Changes proposed in this Pull Request:
As apart of this effort #42043 to surface the new Product Gallery block to users.
This PR transforms the Classic Single Product template to the blocks version with the new Product Gallery block. In addition, it adds the transform function for the legacy Product Image Gallery to the new Product Gallery Block.
Both of these additions will help surface this new Product Gallery block to existing and new users.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Test 1
Test 2
Test 3
pnpm run --filter='@woocommerce/block-library' build:deploy
and thenpnpm run --filter='@woocommerce/plugin-woocommerce' build
.Changelog entry
Significance
Type
Message
Comment