Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product Block Editor]: do not use sub registry for the IFrame editor #42882

Closed

Conversation

retrofox
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR sets the useSubRegistry to false to avoid using a sub-registry in the <BlockEditorProvider> instance of the IFrame editor, keeping in mind that both editor instances cannot coexist simultaneously. The goal is to be able to access to the data globally though the select helpers.

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

To access the Product Editor, follow these steps:

  1. Open the dev console
  2. Go to the Product Editor
image
  1. From the store, select the current block instances of the editor
wp.data.select( 'core/block-editor').getBlocks()
  1. Confirm that the block instances are returned.
image

To edit the description field using the Modal editor (IFrame editor wrapper), do the following:

  1. Open the Modal editor.
image
  1. Choose the block instances.
wp.data.select( 'core/block-editor').getBlocks()
  1. Make sure that the instances you see correspond to the Modal editor and not to the Product editor.
image
  1. Close the Modal editor
  2. Confirm the app continues working as expected

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@retrofox retrofox added focus: new product ux revamped product management experience team: Mothra WC Merchants activation and store management labels Dec 15, 2023
@retrofox retrofox requested a review from a team December 15, 2023 18:48
@retrofox retrofox self-assigned this Dec 15, 2023
Copy link
Contributor

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Test Results Summary

Commit SHA: 1619f5c

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests258003026114m 9s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@retrofox
Copy link
Contributor Author

Closing because of #42761 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: new product ux revamped product management experience team: Mothra WC Merchants activation and store management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant