Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews by Product block: fix encoded in input aria-label #42944

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Dec 19, 2023

Changes proposed in this Pull Request:

While working on #42903 I noticed we weren't decoding the Product name when it's used in the Reviews by Products selector as the input aria-label. This small PR should handle that.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a product with special characters in its name. Ie: Fish & Chips.
  2. Create a new post or page and add the Reviews by Product block.
  3. Verify there are no encoded characters in the input field aria-label. You can test that with a screen reader or directly with the browser devtools: press F12Inspector → and inspect the checkbox next to the product name.
Before After
Captura de pantalla de 2023-12-19 10-26-13 Captura de pantalla de 2023-12-19 10-26-22

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Reviews by Product block: decode the product name in the Product selector input aria-label

Comment

@Aljullu Aljullu added focus: accessibility The issue/PR is related to accessibility. block: reviews by product Issues related to the Reviews by Product block. labels Dec 19, 2023
@Aljullu Aljullu self-assigned this Dec 19, 2023
@Aljullu Aljullu requested review from a team and tjcafferkey and removed request for a team December 19, 2023 09:32
Copy link
Contributor

Hi @tjcafferkey,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

@tjcafferkey tjcafferkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this fixes the issue. LGTM and nice catch.

@Aljullu Aljullu force-pushed the fix/reviews-by-product-encoded-entities-aria-label branch from 542d0cd to f3b9d96 Compare December 19, 2023 09:57
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 19, 2023
Copy link
Contributor

github-actions bot commented Dec 19, 2023

Test Results Summary

Commit SHA: f3b9d96

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests258003026114m 51s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@Aljullu Aljullu merged commit 06e5b43 into trunk Dec 19, 2023
26 checks passed
@Aljullu Aljullu deleted the fix/reviews-by-product-encoded-entities-aria-label branch December 19, 2023 12:05
@github-actions github-actions bot added this to the 8.5.0 milestone Dec 19, 2023
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Dec 19, 2023
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block: reviews by product Issues related to the Reviews by Product block. focus: accessibility The issue/PR is related to accessibility. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants