New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYS - Ensure the offline modal is displayed whenever AI is unavailable #42949
Conversation
Test Results SummaryCommit SHA: f1d361e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
Hi @chihsuan, @gigitux, @nefeline, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
However, I noticed that when I click on Customize
button in intro screen, and AI is offline, I see the offline modal as well. Is it expected?
Screen.Recording.2023-12-20.at.17.17.21.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Confirmed that the correct modals are displayed depending on whether AI is down and if the store owner already finished the onboarding flow.
I could also reproduce this; we should skip displaying the modal when customizing the store. |
Good catch @chihsuan! I don't think that should be the case, do you know how can I control that case? |
Hey @albarin I think we can probably append a query parameter to customize the button URL to know if the user is customizing. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Re-ran the tests and confirmed that:
✅ Offline modal is displayed if AI is down
✅ Modal is not displayed if AI is up and running
✅ On initial store setup, when AI is down the modal also includes the initial tour.
✅ When clicking on the "Customize" button on the intro screen, and AI is offline, the offline modal is not displayed.
Submission Review Guidelines:
Changes proposed in this Pull Request:
The goal of this PR is to show the AI offline modal always when the AI is unavailable, independently from the onboarding tour.
For that, a new
AiOfflineModal
component is created and extracted from theOnboardingTour
component.Closes #42905
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Case 1: after first creation
customize-store
feature flag in Tools -> WCA Test Helper -> Features.Customize your store
task.major
.Case 2: when customizing an existing store
Done
to confirm the store design.Customize your store
task again.Customize
button.Changelog entry
Significance
Type
Message
Ensure the offline modal is displayed whenever AI is unavailable and not just on the initial store setup.
Comment