Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for product meta lookup table incorrectly marking a product as onsale Closes #43008 #43011

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Fix for product meta lookup table incorrectly marking a product as onsale Closes #43008 #43011

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d648542
Update wc-product-functions.php
pintend Dec 20, 2023
fc89bfd
Add changefile(s) from automation for the following project(s): wooco…
invalid-email-address Jan 8, 2024
80a7868
added missing placeholders
pintend Jan 31, 2024
a0478de
Update 43011-patch-1
jorgeatorres Mar 1, 2024
5e74946
Add changefile(s) from automation for the following project(s): wooco…
invalid-email-address Mar 1, 2024
2236670
Re-trigger CI
jorgeatorres Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/43011-patch-1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Use regular_price to determine if product is not sale and don't rely only on price for product_meta_lookup.
4 changes: 4 additions & 0 deletions plugins/woocommerce/includes/wc-product-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,14 +1562,18 @@ function wc_update_product_lookup_tables_column( $column ) {
{$wpdb->wc_product_meta_lookup} lookup_table
LEFT JOIN {$wpdb->postmeta} meta1 ON lookup_table.product_id = meta1.post_id AND meta1.meta_key = '_price'
LEFT JOIN {$wpdb->postmeta} meta2 ON lookup_table.product_id = meta2.post_id AND meta2.meta_key = '_sale_price'
LEFT JOIN {$wpdb->postmeta} meta3 ON lookup_table.product_id = meta3.post_id AND meta3.meta_key = '_regular_price'
SET
lookup_table.`{$column}` = IF (
CAST( meta1.meta_value AS DECIMAL ) >= 0
AND CAST( meta2.meta_value AS CHAR ) != ''
AND CAST( meta1.meta_value AS DECIMAL( 10, %d ) ) = CAST( meta2.meta_value AS DECIMAL( 10, %d ) )
AND CAST( meta3.meta_value AS DECIMAL( 10, %d ) ) > CAST( meta2.meta_value AS DECIMAL( 10, %d ) )
jorgeatorres marked this conversation as resolved.
Show resolved Hide resolved
, 1, 0 )
",
$decimals,
$decimals,
$decimals,
$decimals
)
);
Expand Down