Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Pexels product images width to 400px to have a better resolution #43174

Merged
merged 2 commits into from Jan 2, 2024

Conversation

albarin
Copy link
Contributor

@albarin albarin commented Dec 29, 2023

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR increases the with of the images retrieved from the Pexels API to 400px to improve the resolution.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Initial Setup

  1. Create a new WooCommerce installation with this version.
  2. Ensure Jetpack is installed and your site is connected with JP.
  3. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  4. Ensure the Woo AI plugin is installed and activated (available on this monorepo).
  5. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag:

Testing steps

  1. Head over to WooCommerce -> Home and click on "Start Customizing".
  2. Click the Design with AI button.
  3. Fill out a business description and proceed.
  4. Make sure the product images in product patterns is good and the images are not blurry.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Increase product images width to 400px to have a better resolution

Comment

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 29, 2023
@albarin albarin marked this pull request as ready for review December 29, 2023 12:27
@woocommercebot woocommercebot requested review from a team and nefeline and removed request for a team December 29, 2023 12:27
Copy link
Contributor

github-actions bot commented Dec 29, 2023

Hi @gigitux, @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

Hi @nefeline,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Dec 29, 2023

Test Results Summary

Commit SHA: 37279c8

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests258003026114m 10s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@albarin albarin requested a review from gigitux January 2, 2024 08:19
@albarin albarin force-pushed the increase-pexels-image-width branch from 3ca350f to 37279c8 Compare January 2, 2024 11:35
Copy link
Member

@nefeline nefeline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@albarin albarin merged commit f9cdce4 into trunk Jan 2, 2024
29 checks passed
@albarin albarin deleted the increase-pexels-image-width branch January 2, 2024 12:59
@github-actions github-actions bot added this to the 8.6.0 milestone Jan 2, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 2, 2024
@alopezari alopezari added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 2, 2024
samueljseay pushed a commit that referenced this pull request Jan 3, 2024
…tion (#43174)

* Increase product images width to 400 to have a better resolution

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
samueljseay pushed a commit that referenced this pull request Jan 3, 2024
…tion (#43174)

* Increase product images width to 400 to have a better resolution

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
opr pushed a commit that referenced this pull request Jan 3, 2024
…tion (#43174)

* Increase product images width to 400 to have a better resolution

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants