New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not access change_feature_enable() statically. Closes #43175. #43176
Do not access change_feature_enable() statically. Closes #43175. #43176
Conversation
Hi , Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good - I see this pattern in other places. Apologies for not using the method I saw elsewhere here.
That said, I can't replicate the issue being resolved here. I rebuilt and tried with both the standard and block product editor. No fatals I could see.
This PR is having problems with the automated builds – probably because it's using a forked branch. I don't know a better way to resolve it than to copy Kathy's changes to a new PR: #43428. We'll merge that one. Thanks very much for the fix @helgatheviking! 🙌 |
The build tooling has gotten way to complex for me, but happy to help. Maybe y'all can update the docu on how to submit a PR that passes the build process. |
Changes proposed in this Pull Request:
Do not access
change_feature_enable()
statically.Closes #43175..
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Fix fatal error. Do not access change_feature_enable() statically.
Comment