Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not access change_feature_enable() statically. Closes #43175. #43176

Conversation

helgatheviking
Copy link
Contributor

Changes proposed in this Pull Request:

Do not access change_feature_enable() statically.

Closes #43175..

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Should be able to access site now without fatal error.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Fix fatal error. Do not access change_feature_enable() statically.

Comment

@github-actions github-actions bot added plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution labels Dec 29, 2023
@woocommercebot woocommercebot requested review from a team, coreymckrill, psealock and moon0326 and removed request for a team December 29, 2023 14:21
Copy link
Contributor

github-actions bot commented Dec 29, 2023

Hi ,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@chihsuan chihsuan requested review from bgrgicak, andfinally and kdevnel and removed request for coreymckrill, a team, psealock and moon0326 January 3, 2024 03:58
@chihsuan chihsuan closed this Jan 3, 2024
@chihsuan chihsuan reopened this Jan 3, 2024
Copy link
Contributor

@kdevnel kdevnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good - I see this pattern in other places. Apologies for not using the method I saw elsewhere here.

That said, I can't replicate the issue being resolved here. I rebuilt and tried with both the standard and block product editor. No fatals I could see.

@andfinally
Copy link
Contributor

This PR is having problems with the automated builds – probably because it's using a forked branch. I don't know a better way to resolve it than to copy Kathy's changes to a new PR: #43428. We'll merge that one. Thanks very much for the fix @helgatheviking! 🙌

@andfinally andfinally closed this Jan 10, 2024
@helgatheviking
Copy link
Contributor Author

helgatheviking commented Jan 10, 2024

The build tooling has gotten way to complex for me, but happy to help. Maybe y'all can update the docu on how to submit a PR that passes the build process.

@helgatheviking helgatheviking deleted the issues/#43175-fatal-error-features-controller branch January 10, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. type: community contribution
Projects
None yet
5 participants