Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Gallery: Fix Large Image snapping position on window resize #43251

Conversation

danieldudzic
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes the issue with the Product Gallery Large Image losing focus of the current ("focused") image on browser window resize.

Closes #42852 .

Before After
fl61KTGOaI oOofzECJFs

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Appearance > Editor > Templates > Single Product (clear customizations)
  2. Click on the editor and you should see "Transform into blocks" action button.
  3. Add the Product Gallery block (it's best if it's set to full-width layout).
  4. Open a Product that has multiple images in its gallery.
  5. Scroll to an image (make sure you are not testing on the default, first image).
  6. Ensure the image stays correctly in focus when resizing the browser window.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@woocommercebot woocommercebot requested a review from a team January 3, 2024 15:13
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Hi @roykho, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 3, 2024
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Test Results Summary

Commit SHA: c2c4fd7

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests258003026114m 34s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@roykho roykho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is working as expected. Great work!

@danieldudzic danieldudzic merged commit 7163d61 into trunk Jan 3, 2024
26 checks passed
@danieldudzic danieldudzic deleted the fix/42852-product-gallery-block-snapping-position-on-resize branch January 3, 2024 16:46
@github-actions github-actions bot added this to the 8.6.0 milestone Jan 3, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 3, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Gallery Block: Main image sliding animation issue
3 participants