Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide sale badge if product image is disabled #43334

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Hide sale badge if product image is disabled #43334

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
898bb49
Hide sale badge if product image is disabled
roykho Jan 5, 2024
6af2f46
Fix css target to cover all product grid
roykho Jan 5, 2024
3d78d81
Add changefile(s) from automation for the following project(s): wooco…
invalid-email-address Jan 5, 2024
a29bae8
Hide on sale badge via PHP side
roykho Jan 5, 2024
8b1a5f4
Remove css changes
roykho Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugins/woocommerce-blocks/assets/css/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,12 @@
left: auto;
}

.wc-block-grid[data-content-visibility*='"image":false'] {
.wc-block-grid__product-onsale {
display: none;
}
}

// Element spacing.
.wc-block-grid__product {
// Prevent link and image taking the full width unnecessarily, which might cause: https://github.com/woocommerce/woocommerce-blocks/issues/11438
Expand Down
4 changes: 4 additions & 0 deletions plugins/woocommerce/changelog/43334-fix-on-sale-badge-with-no-image
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Fix on-sale badge covering product title when product image is disabled