CYS: fix PHP warnings and pattern button #43354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Test Results SummaryCommit SHA: 7965529
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
woocommercebot
requested review from
a team and
gigitux
and removed request for
a team
|
Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
albarin
force-pushed
the
fix-cys-php-warnings-and-pattern
branch
from
b68e5ca
to
d0c7714
Compare
nefeline
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Great work @albarin !
Insert the Banner pattern, save, and make sure the button does not have custom styles (see screenshots below).
✅ Confirmed the button doesn't have custom styles
Check the debug.log and make sure there are no PHP warnings related to slug key not being present and $images not being defined.
✅ Confirmed that there are no PHP warnings in the error log.
github-actions
bot
added
the
needs: analysis
rodelgc
added
needs: external testing
5 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Remove custom styles from button * Avoid php warning about images and slug not defined * Add changefile(s) from automation for the following project(s): woocommerce * Add changefile(s) from automation for the following project(s): woocommerce * Fix linting errors --------- Co-authored-by: github-actions <github-actions@github.com>
This was referenced Jan 25, 2024
nigeljamesstevenson
pushed a commit
that referenced
this pull request
Jan 25, 2024
* CYS: fix PHP warnings and pattern button (#43354) * Remove custom styles from button * Avoid php warning about images and slug not defined * Add changefile(s) from automation for the following project(s): woocommerce * Add changefile(s) from automation for the following project(s): woocommerce * Fix linting errors --------- Co-authored-by: github-actions <github-actions@github.com> * Prep for cherry pick 43354 --------- Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: WooCommerce Bot <no-reply@woo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
slugkey not present and$imagesvariable not being defined.Bannerpattern button.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Customize your storeflow, create a new page or post.Bannerpattern, save, and make sure the button does not have custom styles (see screenshots below).debug.logand make sure there are no PHP warnings related toslugkey not being present and$imagesnot being defined.Changelog entry
Significance
Type
Message
Fix PHP warnings and remove opinionated styles from the
Bannerbutton.Comment