Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CYS: fix php warning raise by the Product Collection block #43546

Merged
merged 4 commits into from
Jan 12, 2024
Merged

CYS: fix php warning raise by the Product Collection block #43546

merged 4 commits into from
Jan 12, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Jan 12, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

These PR fixes ensure that the block editor state is updated when some blocks have to load some logic and set attributes dynamically in the editor when the assembler is loaded

Closes #42865.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new WooCommerce installation with this version.
  2. Ensure that you have WP_DEBUG enabled.
  3. Make sure to enable customize-store feature flag.
  4. Go to WooCommerce -> Home and click Customize Store task.
  5. Click Start designing button.
  6. Follow through the flow all the way till the assembler hub shows up.
  7. Go to FE.
  8. Confirm there is no warning.
Before After
image image

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

CYS: fix php warning raise by the Product Collection block.

Comment

@gigitux gigitux added type: bug The issue is a confirmed bug. team: Kirigami & Origami WC Store Editing (FSE) focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Jan 12, 2024
@gigitux gigitux self-assigned this Jan 12, 2024
@gigitux gigitux linked an issue Jan 12, 2024 that may be closed by this pull request
CYS > PHP Warning triggered whenever a pattern with the Product Collection block is inserted via the Assembler #42865
Closed
@woocommercebot woocommercebot requested a review from a team January 12, 2024 09:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited

Hi @albarin, @chihsuan, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited

Test Results Summary

Commit SHA: 01d20f5

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests870019202793m 31s
To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

albarin
albarin approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gigitux
Merge branch 'trunk' of github.com:woocommerce/woocommerce into 42865…
01d20f5 
…-cys-php-warning-triggered-whenever-a-pattern-with-the-product-collection-block-is-inserted-via-the-assembler
@gigitux gigitux merged commit 5edea79 into trunk Jan 12, 2024
28 of 29 checks passed
@gigitux gigitux deleted the 42865-cys-php-warning-triggered-whenever-a-pattern-with-the-product-collection-block-is-inserted-via-the-assembler branch January 12, 2024 12:44
@github-actions github-actions bot added this to the 8.6.0 milestone Jan 12, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 12, 2024
@nigeljamesstevenson nigeljamesstevenson added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 15, 2024
samueljseay pushed a commit that referenced this pull request Jan 16, 2024
@gigitux @samueljseay
CYS: fix php warning raise by the Product Collection block (#43546)
596d59b 
* CYS: fix php warning raise by the Product Collection block

* fix typo

* Add changefile(s) from automation for the following project(s): woocommerce

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albarin albarin albarin approved these changes

@chihsuan chihsuan Awaiting requested review from chihsuan

@nefeline nefeline Awaiting requested review from nefeline

Assignees

@gigitux gigitux

Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami WC Store Editing (FSE) type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
8.6.0
Development

Successfully merging this pull request may close these issues.

CYS > PHP Warning triggered whenever a pattern with the Product Collection block is inserted via the Assembler
3 participants
@gigitux @albarin @nigeljamesstevenson