[Product Block Editor]: relocate block actions in the sections area #43555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results SummaryCommit SHA: d217c4e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
retrofox
force-pushed
the
update/product-editor-download-button-to-sections-actions
branch
from
cfbc1ed
to
fa5110e
Compare
retrofox
added
focus: new product ux
|
Hi @nathanss, @woocommerce/mothra Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
retrofox
changed the title
retrofox
force-pushed
the
update/product-editor-download-button-to-sections-actions
branch
from
53a94b3
to
2d8a14f
Compare
retrofox
commented
Jan 12, 2024
Comment on lines
-118
to
-126
| describe( 'empty state', () => { | ||
| it( 'should show subtitle and "Add new" button', () => { | ||
| const { queryByText } = render( | ||
| <AttributeControl value={ [] } onChange={ () => {} } /> | ||
| ); | ||
| expect( queryByText( 'Add new' ) ).toBeInTheDocument(); | ||
| } ); | ||
| } ); | ||
|
|
There was a problem hiding this comment.
I've removed this test since the button is now transported via a portal to another DOM location. We can try to add a test straight in the SlotFill implementation
retrofox
changed the title
nathanss
approved these changes
Jan 15, 2024
retrofox
force-pushed
the
update/product-editor-download-button-to-sections-actions
branch
from
2d8a14f
to
d217c4e
Compare
retrofox
deleted the
update/product-editor-download-button-to-sections-actions
branch
github-actions
bot
added
the
needs: analysis
nigeljamesstevenson
added
needs: external testing
nigeljamesstevenson
added
the
status: analysis complete
samueljseay
pushed a commit
that referenced
this pull request
Jan 16, 2024
…43555) * handle section actions styles from section block * rename DownloadBlockEdit * remove unneeded wrap el from linked product list * put Choose an Image button in the actions section * move attribute control to block actions section * changelog * remove unused clientId prop * tweak Image button * remove `should show subtitle and "Add new" button` test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR is a follow-up of #43540, which updates section actions for the following blocks:
Closes # .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Significance
Type
Message
Comment