New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GMT date when fetching cancellation orders. #43641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
label
Jan 15, 2024
Test Results SummaryCommit SHA: bd2c611
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
vedanshujain
requested review from
a team,
coreymckrill,
lsinger and
Konamiman
and removed request for
a team and
coreymckrill
January 15, 2024 07:52
Hi @lsinger, @Konamiman, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Konamiman
approved these changes
Jan 15, 2024
github-actions
bot
added
the
needs: analysis
Indicates if the PR requires a PR testing scrub session.
label
Jan 15, 2024
This was referenced Jan 15, 2024
nigeljamesstevenson
pushed a commit
that referenced
this pull request
Jan 15, 2024
* Use GMT date when fetching cancellation orders. (#43641) * Prep for cherry pick 43641 --------- Co-authored-by: Vedanshu Jain <vedanshu.jain.2012@gmail.com> Co-authored-by: WooCommerce Bot <no-reply@woo.com>
nigeljamesstevenson
added
needs: internal testing
Indicates if the PR requires further testing conducted by Solaris
status: analysis complete
Indicates if a PR has been analysed by Solaris
and removed
needs: analysis
Indicates if the PR requires a PR testing scrub session.
labels
Jan 15, 2024
samueljseay
pushed a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs: internal testing
Indicates if the PR requires further testing conducted by Solaris
plugin: woocommerce
Issues related to the WooCommerce Core plugin.
status: analysis complete
Indicates if a PR has been analysed by Solaris
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
In
get_unpaid_orders
the passed$date
parameter is a timezone-based timestamp, but we used it as a UTC-based timestamp. This caused issues as the function will return unpaid orders not yet eligible for cancellation and would cancel it, in timezones that are ahead of UTC (countries towards the east of the GMT line).This is fixed by converting the timestamp to UTC before comparing it with the order-modified timestamps.
Closes #43593
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
wp eval "wc_cancel_unpaid_orders();"
Changelog entry
Significance
Type
Message
Comment