New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CYS - Core] Handling errors during the setup for the NoAI
flow
#43810
[CYS - Core] Handling errors during the setup for the NoAI
flow
#43810
Conversation
…-cys-core-handling-errors-during-the-setup
cc @verofasulo for the design |
Hi @nefeline, @verofasulo, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 1554958
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-approving pending style changes. Another comment apart from what Veronica said, the width of the error notice should be the same as the width of the intro banner.
…-cys-core-handling-errors-during-the-setup
Hey Veronica, you're right! Sorry for the confusion! Now, it should be okay! Cattura.schermo.Jan.19.alle.12-34-38.mp4 |
Thanks, @gigitux! 🙌 Could you also align the spacing with the design, please? 🙏 The spacing between the error message and the Design your own theme section is 24px. Here's the Figma file for reference. Thank you! |
…-cys-core-handling-errors-during-the-setup
Thanks for the feedback, @verofasulo! With 1554958, I fixed the CSS. What do you think? |
It looks great! Thanks, @gigitux 🙏 |
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR implements the handling of errors during the setup. If an error is raised, the merchant will be redirected to the intro page with a message on top:
Cattura.schermo.Jan.19.alle.10-14.mp4
Closes #43780.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/tools.php?page=woocommerce-admin-test-helper
and enablecustomize-store
feature flag.try {
, add this line of code:throw new Error( 'Product creation failed' );
(source code)wp-admin/admin.php?page=wc-admin&path=/customize-store
Please try again
and ensure that the process starts again.Changelog entry
Significance
Type
Message
[CYS - Core] Handling errors during the setup for the
NoAI
flowComment