Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CYS - Core] Handling errors during the setup for the NoAI flow #43810

Merged
merged 10 commits into from Jan 25, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Jan 19, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR implements the handling of errors during the setup. If an error is raised, the merchant will be redirected to the intro page with a message on top:

Cattura.schermo.Jan.19.alle.10-14.mp4

Closes #43780.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Create a new WooCommerce installation with this version.
  2. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  3. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  4. After the try {, add this line of code: throw new Error( 'Product creation failed' ); (source code)
    image
  5. Visit the wp-admin/admin.php?page=wc-admin&path=/customize-store
  6. Follow the process.
  7. Ensure that you are redirected to the intro page with an error message on top.
  8. Click on Please try again and ensure that the process starts again.
  9. Click on the right X to close the message error. Ensure that it works.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

[CYS - Core] Handling errors during the setup for the NoAI flow

Comment

@gigitux gigitux added team: Kirigami & Origami focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Jan 19, 2024
@gigitux gigitux self-assigned this Jan 19, 2024
@gigitux gigitux linked an issue Jan 19, 2024 that may be closed by this pull request
@woocommercebot woocommercebot requested a review from a team January 19, 2024 09:21
@gigitux
Copy link
Contributor Author

gigitux commented Jan 19, 2024

cc @verofasulo for the design

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Hi @nefeline, @verofasulo,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Test Results Summary

Commit SHA: 1554958

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests28700902966m 42s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@verofasulo
Copy link

Thanks @gigitux! 🙏

Could we please make the error message background lighter as per design?

image

I can see that also the close button doesn't reflect the designs— it seems a very light shade of gray.

Here's the page in Figma.

Copy link
Contributor

@albarin albarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving pending style changes. Another comment apart from what Veronica said, the width of the error notice should be the same as the width of the intro banner.

@gigitux
Copy link
Contributor Author

gigitux commented Jan 19, 2024

Thanks @gigitux! 🙏

Could we please make the error message background lighter as per design?

image

I can see that also the close button doesn't reflect the designs— it seems a very light shade of gray.

Here's the page in Figma.

Hey Veronica, you're right! Sorry for the confusion! Now, it should be okay!

Cattura.schermo.Jan.19.alle.12-34-38.mp4

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 19, 2024
@verofasulo
Copy link

Thanks, @gigitux! 🙌

Could you also align the spacing with the design, please? 🙏

image

The spacing between the error message and the Design your own theme section is 24px. Here's the Figma file for reference. Thank you!

@gigitux
Copy link
Contributor Author

gigitux commented Jan 25, 2024

Thanks for the feedback, @verofasulo! With 1554958, I fixed the CSS. What do you think?

image

@verofasulo
Copy link

It looks great! Thanks, @gigitux 🙏

@gigitux gigitux merged commit 0a1c4a6 into trunk Jan 25, 2024
26 checks passed
@gigitux gigitux deleted the 43780-cys-core-handling-errors-during-the-setup branch January 25, 2024 11:04
@github-actions github-actions bot added this to the 8.7.0 milestone Jan 25, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 25, 2024
@veljkho veljkho added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CYS - Core] Handling errors during the setup
4 participants