Add common options to the variations options empty state #44001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdperez86
added
focus: new product ux
github-actions
bot
added
the
plugin: woocommerce
|
Hi @octaedro, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 3d0e9ef
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
mdperez86
force-pushed
the
add/43808-common-options
branch
from
2c11510
to
8a7a4e5
Compare
…ble to set a not default empty state
…rt searching right after the modal is shown
octaedro
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
Good job @mdperez86! The code is testing well here and looks good too.
From what I saw in the designs (AkVNGImLgSqCObTQ3idVn7-fi-3301%3A321179), it seems like we should remove the Add new button as well.
I'll approve this PR and maybe we can tackle that in a follow-up PR.
github-actions
bot
added
the
needs: analysis
thealexandrelara
pushed a commit
that referenced
this pull request
Feb 1, 2024
* Always show Variation options and Variations sections within the Variations tab * Remove woocommerce/product-variations-fields block since it's not needed anymore * Create ProductTShirt image for variation options empty state * Add renderCustomEmptyState to the attribute control component to be able to set a not default empty state * Render a custom empty state for variation options * Adds defaultSearch prop to NewAttributeModal so it can be used to start searching right after the modal is shown * Let the empty state adds an attribute that matches a given text * Add changelog files * Fix linter errors
veljkho
added
needs: internal testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Closes #43808
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
New product editoris enabled under/wp-admin/admin.php?page=wc-settings&tab=advanced§ion=featuresproduct-variation-managementis enabled underFeaturestab from/wp-admin/tools.php?page=woocommerce-admin-test-helper(WooCommerce Beta Tester plugin) is required/wp-admin/admin.php?page=wc-admin&path=/add-productVariationstab a new empty state should be shown in theVariation optionssectionChangelog entry
Significance
Type
Message
Comment