New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental] Filter block: replace custom upgrade panel by Transforms API #44024
Conversation
Hi @samueljseay, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: df3871e
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, again another great simplification. Tests well, my only question is, we don't really support downgrade now do we? But I think that's probably fine, since we can just "undo" or not save changes if something went wrong.
Love this, the transform API is much nicer than upgrade/downgrade. 🚢
Yeah, I decided to not support downgrade because of this and we will deprecate existing filter blocks. |
Submission Review Guidelines:
Changes proposed in this Pull Request:
This PR:
Closes #43732 .
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Product Filter
, see the preview that match with actual filter blocks.Product Filter
, see the existing filter block is replaced with new ones, with all customized setting carried over.Changelog entry
Significance
Type
Message
Comment