Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Filter block: replace custom upgrade panel by Transforms API #44024

Merged
merged 5 commits into from Jan 25, 2024

Conversation

dinhtungdu
Copy link
Member

@dinhtungdu dinhtungdu commented Jan 24, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR:

Closes #43732 .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Add the current Active Filters block to the page.
  2. Customize that block:
  • Heading: move it below the filter block, change the content, customize the styling
  • Filter block: change default sidebar setting, customize styling.
  1. Click on the icon of the filter wrapper block to open the block Transforms UI.
  2. See Product Filter option there.
  3. Hover on the Product Filter, see the preview that match with actual filter blocks.
  4. Click on the Product Filter, see the existing filter block is replaced with new ones, with all customized setting carried over.
  5. Repeat steps 2-6 with other filter blocks and see the same results.
Before After

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

@dinhtungdu dinhtungdu self-assigned this Jan 24, 2024
@woocommercebot woocommercebot requested a review from a team January 24, 2024 04:41
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Hi @samueljseay, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Test Results Summary

Commit SHA: df3871e

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests29100502966m 28s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Contributor

@samueljseay samueljseay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, again another great simplification. Tests well, my only question is, we don't really support downgrade now do we? But I think that's probably fine, since we can just "undo" or not save changes if something went wrong.

Love this, the transform API is much nicer than upgrade/downgrade. 🚢

@dinhtungdu
Copy link
Member Author

Tests well, my only question is, we don't really support downgrade now do we? But I think that's probably fine, since we can just "undo" or not save changes if something went wrong.

Yeah, I decided to not support downgrade because of this and we will deprecate existing filter blocks.

@dinhtungdu dinhtungdu merged commit 1abefd5 into trunk Jan 25, 2024
39 of 40 checks passed
@dinhtungdu dinhtungdu deleted the fix/43732-use-block-transforms-api branch January 25, 2024 08:28
@github-actions github-actions bot added this to the 8.7.0 milestone Jan 25, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 25, 2024
@nigeljamesstevenson nigeljamesstevenson added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace block upgrade panel by Block Transforms UI
3 participants