Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving webhooks doc #44098

Merged
merged 4 commits into from
Feb 1, 2024
Merged

moving webhooks doc #44098

merged 4 commits into from
Feb 1, 2024

Conversation

brentmackinnon
Copy link
Contributor

Submission Review Guidelines:

Changes proposed in this Pull Request:

Adds frontmatter to Webhooks document, moves it into a category and updates manifest

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. confirm frontmatter, confirm appropriate file location, and ensure the manifest adjustment looks appropriate.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

Copy link
Contributor

Hi @JacklynBiggin,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Test Results Summary

Commit SHA: 031ea19

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 37s
E2E Tests2870219030818m 11s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

Copy link
Member

@JacklynBiggin JacklynBiggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to move to the Building a Woo Store category

@JacklynBiggin JacklynBiggin enabled auto-merge (squash) February 1, 2024 19:33
@JacklynBiggin JacklynBiggin merged commit 2249b7a into trunk Feb 1, 2024
23 of 25 checks passed
@JacklynBiggin JacklynBiggin deleted the docs-move-webhooks branch February 1, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants