[e2e tests] Add downloadable product test

[adimoldovan]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Closes https://github.com/woocommerce/woocommerce-quality/issues/612 .

Cover the add downloadable product flow.

Changes:

• renamed the create-simple-product.spec.js spec file to product-create-simple.spec.js to be consistent with the pattern product-<action> used by most spec files (also updated the docs/quality-and-best-practices/core-critical-flows.md doc as an effect).
• I used a for loop to merge the resulting 3 tests into a single parametrised test function to reduce code duplication. My first intention was to have 3 tests and extract the common parts into functions, but I think in the end this version is cleaner and more readable.
• With merging all tests into one function I added some extra checks for the virtual and non-virtual products.
• I also enabled the fullPage option for screenshots.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Run the spec locally with pnpm end:restart && pnpm test:e2e-pw ./tests/e2e-pw/tests/merchant/product-create-simple.spec.js

⚠️ The MarkdownLint on PR / lint check is failing because I updated a doc file and the check asks for an update of the docs-manifest, but this is not required for updates of content only.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 1745bdc

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 36s
E2E Tests	282	0	0	16	0	298	7m 2s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[github-actions]

Hi , @woocommerce/solaris, @woocommerce/vortex

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[rrennick]

@adimoldovan When you change .md files in the docs folder you need to update the docs manifest. Run the following in the root of the repository:

pnpm utils md-docs docs woocommerce -o docs/docs-manifest.json

[adimoldovan]

@adimoldovan When you change .md files in the docs folder you need to update the docs manifest. Run the following in the root of the repository:

pnpm utils md-docs docs woocommerce -o docs/docs-manifest.json

Hi @rrennick, I wanted to generate the manifest when I saw the failed job, but according to the contributing-docs I don't have to: You don't need to regenerate the manifest if you only make changes to a page's content. My PR only updates the content of a page. Do I still need to regenerate the manifest?

[rrennick]

You don't need to regenerate the manifest if you only make changes to a page's content.

That's an error in the instructions. We should have those updated later this week.

[rrennick]

LGTM