-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Release: Update usage of NPM auth token #44215
Conversation
Hi @rrennick, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
Test Results SummaryCommit SHA: 41404fb
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Thanks @psealock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psealock This is failing CI because the changes output a warning before the project graph:
WARN Issue while reading "/Users/ronrennick/Sites/wc/wp-content/woocommerce/.npmrc". Failed to replace env in config: ${NODE_AUTH_TOKEN}
Locally for me, NODE_AUTH_TOKEN
is not set when running ci-jobs
.
@ObliviousHarmony @rrennick I've changed this up such that authentication is set in the action itself instead of inside
woocommerce/.github/workflows/package-release.yml Lines 35 to 38 in 5279d3d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tested great @psealock
* update .npmrc * try project specific .npmrc * try whoami * try package .npmrc * whitespace * try in tool * try adding line * set auth explicitly * test whoami * does this work? * add script call
Submission Review Guidelines:
Changes proposed in this Pull Request:
NPM auth token was being incorrectly used, this PR fixes it according to NPM docs.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
fix/npm-auth-token-use
) and the@woocommerce/create-woo-extension
package.1.1.0
version successfully published at the end of the section's logsChangelog entry
Significance
Type
Message
Comment