Remove the ability to update Woo.com extensions not available in WP.org plugin directory

[thilinah]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

• This PR removes the ability to update Woo.com hosted plugins, through WP plugin.php.
• No auto-updates will be available for Woo.com hosted plugins.
• The update button, on WooCommerce -> Extensions -> My Subscription, shows a modal asking the user to install Woo Update Manager if it's not installed.
• Add an endpoint under wccom-site API for checking if the Woo Update Manager plugin is available.
• Change the name of the Woo Connect plugin to Woo Update Manager on all the places (my-subscriptions tab / modals / plugin update notices / admin notices)
• Add an admin notice on WC admin pages to notify the user about Woo Update Manager plugin.
• Change the install URL structure to include the product id of the Woo Update Manager plugin.

Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Assets for testing

• woocommerce.zip
• woo-update-manager.zip

Testing the removal of plugin update functionality

1. Start the development environment pnpm -- wp-env start
2. Visit WCCore My Subscriptions page, credentials can be found under wp-env documentation
3. Make sure you have a Woo.com account and subscription for a product listed in WP.org and a product not listed in WP.org. I've used Square and AutomateWoo
4. Connect your Woo.com account.
5. Install Square extension via My Subscriptions.
6. Notice the current version is updated.

7. Use pnpm -- wp-env run cli bash to change the version of the Square extension to an older version, by editing woocommerce-square.php.

8. Notice that now an Update button is shown in for this plugin My Subscriptions

9. Under the WP plugins page also the update notice should be displayed.

10 You should be able to update Square, since it's hosted in WP.org.

11. Install AutomateWoo manually. (Woo.com auto install process won't work since the site is hosted locally).
12. You should be able to see the current version of AutomateWoo under My Subscriptions.

13. Use pnpm -- wp-env run cli bash to change the version of AutomateWoo to an older version.

14. The WP plugin page won't display the update button, but a message to install woo marketplace plugin will be displayed to the user.

15. But the My Subscriptions should show the update button.

Testing Notifications

Changes to the notifications are based on what discussed in this P2: https://woomarketplace.wordpress.com/2024/02/13/woo-connect-plugin-flows-i2/

1. Start the development environment pnpm -- wp-env start and build assets using pnpm --filter='@woocommerce/plugin-woocommerce' build
2. Make sure your site is connected to WOO.COM.
3. Make sure the market place plugin isn't installed and at least one of your Woo subscriptions are out dated. You can achieve this by using pnpm -- wp-env run cli bash to change the version of AutomateWoo (or another Woo.com plugin) to an older version.
4. Visit discover extensions tab and notice the message shown to the user. (The action button links on the message aren't finalized yet).

5. Visit my-subscriptions tab and the same message should be displayed.

6. On the plugin management page a notification should be displayed asking to install Woo Connect.

7. When the user tried to update a connected subscription they should see the following message if Woo Connect isn't installed.

8. Install the Woo Update Manager plugin but keep it deactivated. Refresh my-subscriptions tab to notice that the notification has changed. Latest version of the plugin can be downloaded under Assets for Testing section at the top of the test instructions.

9. The message should be same on discover extensions tab

10. On the plugin management page a notification should be displayed asking to activate Woo Connect.

11. Disconnect the store and notice the new connect message.

12. When the Woo Update Manager plugin isn't installed there should be WC admin notices shown on WC Admin pages such as orders, settings, reports and status.

Testing wccom-site API status endpoint

1. Start the development environment pnpm -- wp-env start
2. Make sure your site is connected to WOO.COM
3. Run these commands to find the access token for the connected site using woocommerce_helper_data option

pnpm -- wp-env run cli bash
wp shell
get_option('woocommerce_helper_data');

11. Use the access token in the above option to replace <access_token> in the url below:

curl -X GET http://localhost:8888/index.php?rest_route=/wccom-site/v3/status&token=<access_token>&signature=1

14. Temporarily update \WC_WCCOM_Site::verify_wccom_request function always return true;
15. The updated CURL command in step 4 should give a successful response.

{"success":true,"data":{"wc_version":"8.7.0","woo_marketplace_plugin_active":false}}

Testing installtion URL on customer site with woocommerce.test

1. Use this WC build under Assets for Testing section at the top of the test instructions.

2. Add the following filter on customer mu-plugins to change installation URL to woocommerce.test

add_filter( 'woo_com_base_url', function( $base ) {
	return 'https://woocommerce.test/';
} );

3. Notice that the installation URL generated on install notice, contains the product ID, access token and the signature.
   .

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

Comment

[github-actions]

Test Results Summary

Commit SHA: 75cbfd2

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 38s
E2E Tests	309	0	0	48	0	357	7m 49s

---

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

[thilinah]

@anaspk thanks for the review:

There is some HTML markup added to the page title.

This is fixed with 19bb02c and 41c3b3b

The red dot is missing from the "My subscriptions" tab.

I've intentionally skip this as there is no component for adding the bubble. As this is not an important indicator given the bubble on extensions menu is shown, this will be covered in another PR.

The red dot doesn't appear on WooCommerce -> Extensions menu item in the sidebar too if there are no existing updates available.

Fixed with 7681e62

[thilinah]

There is just one small issue I'm describing below.
Under WC 8.6.1, when subscription for product is not connected/activated, Update now action is shown.
With this PR, it simply says "Automatic update is unavailable for this plugin" without any hint on how to resolve the issue.

Thanks for reporting this @denho. This is something that can be resolved in Woo Update Manger. I'll do some testing and add a fix to Woo Update Manager repo.