Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYS - AI flow: fix regression - no fonts visible #44280

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

gigitux
Copy link
Contributor

@gigitux gigitux commented Feb 1, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

This PR fixes a regression caused by #44004. The wrong component is rendered when the flow is AIOnline.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

JN Installation

  1. Create a new WooCommerce installation with this version.
  2. Ensure Jetpack is installed and your site is connected with JP.
  3. Ensure the WooCommerce Beta Tester plugin is installed and activated (available on this monorepo).
  4. Ensure the Woo AI plugin is installed and activated (available on this monorepo).
  5. Head over to /wp-admin/tools.php?page=woocommerce-admin-test-helper and enable customize-store feature flag.
  6. Head over to WooCommerce -> Home and click on "Start Customizing".
  7. Ensure that all the flow works correctly.
  8. On the sidebar, select change your font and ensure that the fonts are visible.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

CYS - AI flow: fix regression - no fonts visible

@gigitux gigitux added team: Kirigami & Origami focus: customize-your-store Issues related to the Customize Your Store onboarding flow. labels Feb 1, 2024
@gigitux gigitux self-assigned this Feb 1, 2024
@woocommercebot woocommercebot requested a review from a team February 1, 2024 18:06
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Hi @albarin, @nefeline, @woocommerce/woo-fse

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@gigitux gigitux marked this pull request as draft February 1, 2024 18:09
@gigitux gigitux marked this pull request as ready for review February 1, 2024 18:09
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Feb 1, 2024
Copy link
Contributor

github-actions bot commented Feb 1, 2024

Test Results Summary

Commit SHA: 0ab82cb

Test 🧪Passed ✅Failed 🚨Broken 🚧Skipped ⏭️Unknown ❔Total 📊Duration ⏱️
API Tests25900202610m 36s
E2E Tests266014103089m 13s

⚠️ Warning

Please address the following issues prior to merging this pull request:
  • FAILED/BROKEN TESTS. There were failed and/or broken API and E2E tests.

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

@gigitux gigitux enabled auto-merge (squash) February 1, 2024 18:20
@gigitux gigitux merged commit ae1503f into trunk Feb 1, 2024
23 of 25 checks passed
@gigitux gigitux deleted the fix/font-ai-flow-no-visible branch February 1, 2024 18:44
@github-actions github-actions bot added this to the 8.7.0 milestone Feb 1, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Feb 1, 2024
@veljkho veljkho added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: internal testing Indicates if the PR requires further testing conducted by Solaris plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris team: Kirigami & Origami
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants