CYS - Core: Font Library: disable the installation of the fonts #44311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
changed the title
Test Results SummaryCommit SHA: 0df9a34
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
gigitux
added
focus: customize-your-store
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
|
Hi @samueljseay, @adimoldovan, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
…erce into fix/e2e-test-failure
github-actions
bot
added
the
plugin: woocommerce
adimoldovan
approved these changes
Feb 2, 2024
albarin
approved these changes
Feb 2, 2024
github-actions
bot
added
the
needs: analysis
11 tasks
nigeljamesstevenson
added
needs: external testing
samueljseay
pushed a commit
that referenced
this pull request
Feb 6, 2024
* avoid crash when Gutenberg is not installed * add issue link * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Currently, the installation of the fonts is available only when a specific version of Gutenberg is installed. Even if the CYS Core flow is still WIP to avoid that E2E tests fail, we are disabling it.
For more details, check #44315.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/tools.php?page=woocommerce-admin-test-helperand enablecustomize-storefeature flag.wp-admin/admin.php?page=wc-admin&path=/customize-store.Changelog entry
Significance
Type
Message
Comment
CYS - Core: Font Library: Avoid crashing when Gutenberg is not installed.